Various improvements to profiling sample label generator#5316
Merged
Conversation
…'t attach it to idle samples) - Bail out faster when it's not present - Handle soon-to-be-introduced context.asyncId
Contributor
Overall package sizeSelf size: 8.81 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5316 +/- ##
==========================================
- Coverage 81.17% 80.70% -0.48%
==========================================
Files 482 485 +3
Lines 21530 21814 +284
==========================================
+ Hits 17478 17605 +127
- Misses 4052 4209 +157 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 674 Passed, 0 Skipped, 17m 58.19s Total Time |
BridgeAR
reviewed
Feb 25, 2025
BridgeAR
left a comment
BridgeAR
left a comment
Member
There was a problem hiding this comment.
Code is LGTM. Can you please add a test as well?
BridgeAR
reviewed
Feb 25, 2025
BenchmarksBenchmark execution time: 2025-02-26 15:38:52 Comparing candidate commit ccaba08 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 909 metrics, 24 unstable metrics. |
szegedi
force-pushed
the
szegedi/defensive-labels
branch
from
February 26, 2025 15:27
5538118 to
ccaba08
Compare
nsavoire
approved these changes
Feb 26, 2025
BridgeAR
approved these changes
Feb 26, 2025
Merged
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
* - Allow for context.context not being defined (newer pprof-nodejs won't attach it to idle samples) - Bail out faster when it's not present - Handle soon-to-be-introduced context.asyncId * Add a comment, better express type expectations * Test the label generator
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
* - Allow for context.context not being defined (newer pprof-nodejs won't attach it to idle samples) - Bail out faster when it's not present - Handle soon-to-be-introduced context.asyncId * Add a comment, better express type expectations * Test the label generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
context.contextnot being definedcontext.asyncIdMotivation
A version of pprof-nodejs in the works streamlines few things. As a consequence,
context.contextcan sometimes be undefiined. also,context.asyncIdwill start appearing.Additional Notes
Jira: PROF-11371