Skip to content

Do not expose internals#5313

Merged
BridgeAR merged 1 commit into
masterfrom
BridgeAR/cleanup_variables
Feb 25, 2025
Merged

Do not expose internals#5313
BridgeAR merged 1 commit into
masterfrom
BridgeAR/cleanup_variables

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

The timeout and the flush can be handled without any variables. This way nothing is added to the instance.

The timeout and the flush can be handled without any variables.
This way nothing is added to the instance.
@BridgeAR
BridgeAR requested a review from a team as a code owner February 24, 2025 21:59
@BridgeAR
BridgeAR requested a review from bengl February 24, 2025 22:00
@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (ac25f30) to head (f3806f5).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5313      +/-   ##
==========================================
- Coverage   80.94%   80.83%   -0.12%     
==========================================
  Files         488      487       -1     
  Lines       21853    21745     -108     
==========================================
- Hits        17690    17577     -113     
- Misses       4163     4168       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: BridgeAR/cleanup_variables
Commit report: b65aefb
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 663 Passed, 0 Skipped, 10m 57.41s Total Time

@pr-commenter

pr-commenter Bot commented Feb 24, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-02-24 22:07:27

Comparing candidate commit f3806f5 in PR branch BridgeAR/cleanup_variables with baseline commit ac25f30 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

@BridgeAR

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow

dd-devflow Bot commented Feb 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.
2025-02-25 13:25:06 UTC ℹ️ Start processing command /merge


2025-02-25 13:25:16 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-25 15:15:44 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@BridgeAR

Copy link
Copy Markdown
Member Author

/remove

@dd-devflow

dd-devflow Bot commented Feb 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.
2025-02-25 15:15:36 UTC ℹ️ Start processing command /remove


2025-02-25 15:15:38 UTC ℹ️ Devflow: /remove

@BridgeAR
BridgeAR merged commit 9f5b7c4 into master Feb 25, 2025
@BridgeAR
BridgeAR deleted the BridgeAR/cleanup_variables branch February 25, 2025 15:15
watson pushed a commit that referenced this pull request Feb 27, 2025
The timeout and the flush can be handled without any variables.
This way nothing is added to the instance.
@watson watson mentioned this pull request Feb 27, 2025
watson pushed a commit that referenced this pull request Feb 27, 2025
The timeout and the flush can be handled without any variables.
This way nothing is added to the instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants