lazy load dsm only when needed by rochdev · Pull Request #5305 · DataDog/dd-trace-js

rochdev · 2025-02-21T01:05:21Z

What does this PR do?

Lazy load DSM only when needed.

Motivation

DSM loads a lot of code and some pretty heavy dependencies which increase startup time when not needed.

rochdev · 2025-02-21T01:05:55Z

@@ -0,0 +1,53 @@
+'use strict'


The helpers in this file were copied from processor.js untouched.

github-actions · 2025-02-21T01:06:10Z

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2025-02-21T01:08:25Z

Codecov Report

Attention: Patch coverage is 78.46154% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (96bb84a) to head (1cea28d).
Report is 21 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/dd-trace/src/datastreams/size.js	50.00%	12 Missing ⚠️
packages/dd-trace/src/tracer.js	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5305      +/-   ##
==========================================
- Coverage   80.94%   80.87%   -0.07%     
==========================================
  Files         488      487       -1     
  Lines       21844    21735     -109     
==========================================
- Hits        17681    17579     -102     
+ Misses       4163     4156       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datadog-datadog-prod-us1 · 2025-02-21T01:11:31Z

Datadog Report

Branch report: lazy-load-dsm
Commit report: f0fa90f
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 674 Passed, 0 Skipped, 17m 13.23s Total Time

pr-commenter · 2025-02-21T01:15:27Z

Benchmarks

Benchmark execution time: 2025-02-25 01:47:58

Comparing candidate commit 1cea28d in PR branch lazy-load-dsm with baseline commit 96bb84a in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 915 metrics, 15 unstable metrics.

scenario:spans-finish-later-22

🟩 instructions [-255.1M instructions; -195.4M instructions] or [-8.940%; -6.848%]

scenario:startup-with-tracer-22

🟥 cpu_user_time [+12.683ms; +19.543ms] or [+6.783%; +10.452%]
🟥 execution_time [+13.981ms; +15.577ms] or [+6.063%; +6.755%]

BridgeAR

LGTM % comment addressed

BridgeAR · 2025-02-24T14:47:54Z

+    LazyClass.prototype[method] = function (...args) {
+      const ActiveClass = classGetter()
+      const instance = new ActiveClass(...constructorArgs)
+
+      Object.setPrototypeOf(this, instance)
+
+      return this[method](...args)
+    }


Please add a comment that explains how this replaces all prototype replaced methods in one go.

Please add a separate TODO (including a time frame for a lintrule similar to how unicorn does it https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/expiring-todo-comments.md) that this is going to be replaced with a system that encapsulates modules and have dedicates plugins for that module or feature.

Actually writing the comments made me realize the code can be simplified a bit so I refactored it. I also added the comments and TODO as requested, but I didn't add a time frame as this is not really something we do today, and I felt like this would need to be properly discussed and the linter capability added first.

Any other concerns with the PR?

BridgeAR

LGTM

* lazy load dsm only when needed * code cleanup * refactor and add comments

lazy load dsm only when needed

cffddb0

rochdev added the semver-patch label Feb 21, 2025

rochdev commented Feb 21, 2025

View reviewed changes

code cleanup

4d315a9

rochdev marked this pull request as ready for review February 21, 2025 01:44

rochdev requested review from a team as code owners February 21, 2025 01:44

BridgeAR previously approved these changes Feb 24, 2025

View reviewed changes

refactor and add comments

1cea28d

rochdev dismissed BridgeAR’s stale review via 1cea28d February 25, 2025 01:39

BridgeAR approved these changes Feb 25, 2025

View reviewed changes

BridgeAR merged commit bcf7e61 into master Feb 25, 2025

BridgeAR deleted the lazy-load-dsm branch February 25, 2025 20:52

watson pushed a commit that referenced this pull request Feb 27, 2025

lazy load dsm only when needed (#5305)

2463e33

* lazy load dsm only when needed * code cleanup * refactor and add comments

watson mentioned this pull request Feb 27, 2025

v5.39.0 proposal #5337

Merged

watson pushed a commit that referenced this pull request Feb 27, 2025

lazy load dsm only when needed (#5305)

17070dd

* lazy load dsm only when needed * code cleanup * refactor and add comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

lazy load dsm only when needed#5305

lazy load dsm only when needed#5305
BridgeAR merged 3 commits into
masterfrom
lazy-load-dsm

rochdev commented Feb 21, 2025

Uh oh!

rochdev Feb 21, 2025

Uh oh!

github-actions Bot commented Feb 21, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Feb 21, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot commented Feb 21, 2025 •

edited

Loading

Uh oh!

pr-commenter Bot commented Feb 21, 2025 •

edited

Loading

Uh oh!

BridgeAR left a comment

Uh oh!

BridgeAR Feb 24, 2025

Uh oh!

rochdev Feb 25, 2025

Uh oh!

rochdev Feb 25, 2025

Uh oh!

BridgeAR left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rochdev commented Feb 21, 2025

What does this PR do?

Motivation

Uh oh!

rochdev Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

codecov Bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

datadog-datadog-prod-us1 Bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

pr-commenter Bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:spans-finish-later-22

scenario:startup-with-tracer-22

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

rochdev Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

rochdev Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Feb 21, 2025 •

edited

Loading

codecov Bot commented Feb 21, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Feb 21, 2025 •

edited

Loading

pr-commenter Bot commented Feb 21, 2025 •

edited

Loading