Skip to content

lazy load span leak detection only when used#5259

Merged
rochdev merged 2 commits into
masterfrom
lazy-span-leak
Feb 25, 2025
Merged

lazy load span leak detection only when used#5259
rochdev merged 2 commits into
masterfrom
lazy-span-leak

Conversation

@rochdev

@rochdev rochdev commented Feb 12, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Lazy load span leak detection only when used.

Motivation

This is only a debugging tool and should only be loaded when used.

@github-actions

github-actions Bot commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (8e8898d) to head (8268b99).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/opentracing/span.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5259      +/-   ##
==========================================
- Coverage   81.24%   80.63%   -0.61%     
==========================================
  Files         487      472      -15     
  Lines       21703    21134     -569     
==========================================
- Hits        17633    17042     -591     
- Misses       4070     4092      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Feb 12, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: lazy-span-leak
Commit report: 289b00a
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 15m 51.23s Total Time

@pr-commenter

pr-commenter Bot commented Feb 12, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-02-25 00:07:42

Comparing candidate commit 8268b99 in PR branch lazy-span-leak with baseline commit 8e8898d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 907 metrics, 26 unstable metrics.

@rochdev
rochdev marked this pull request as ready for review February 12, 2025 23:01
@rochdev
rochdev requested a review from a team as a code owner February 12, 2025 23:01
tlhunter
tlhunter previously approved these changes Feb 19, 2025
BridgeAR
BridgeAR previously approved these changes Feb 24, 2025
Comment thread packages/dd-trace/src/opentracing/span.js
@rochdev
rochdev dismissed stale reviews from BridgeAR and tlhunter via 8268b99 February 24, 2025 23:56
@rochdev
rochdev merged commit a1cd027 into master Feb 25, 2025
@rochdev
rochdev deleted the lazy-span-leak branch February 25, 2025 21:48
@watson watson mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants