[DSM] Add messaging.destination tag to spans so they show up in queue pages#5239
Merged
ericfirth merged 1 commit intoFeb 24, 2025
Merged
Conversation
Contributor
Overall package sizeSelf size: 8.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5239 +/- ##
==========================================
- Coverage 81.26% 79.68% -1.59%
==========================================
Files 487 471 -16
Lines 21706 20729 -977
==========================================
- Hits 17640 16518 -1122
- Misses 4066 4211 +145 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 669 Passed, 0 Skipped, 16m 12.97s Total Time |
ericfirth
force-pushed
the
eric.firth/add-messaging-destination-tag-to-node
branch
from
February 10, 2025 19:20
dc52d7d to
bb345d2
Compare
BenchmarksBenchmark execution time: 2025-02-21 16:10:00 Comparing candidate commit c7accfb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 909 metrics, 24 unstable metrics. |
ericfirth
force-pushed
the
eric.firth/add-messaging-destination-tag-to-node
branch
from
February 12, 2025 18:47
bb345d2 to
526325d
Compare
ericfirth
force-pushed
the
eric.firth/add-messaging-destination-tag-to-node
branch
from
February 21, 2025 15:51
526325d to
33dab98
Compare
ericfirth
force-pushed
the
eric.firth/add-messaging-destination-tag-to-node
branch
from
February 21, 2025 15:59
33dab98 to
c7accfb
Compare
wconti27
approved these changes
Feb 24, 2025
ericfirth
deleted the
eric.firth/add-messaging-destination-tag-to-node
branch
February 24, 2025 19:15
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
Merged
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order for kafka queues to show up on the Service catalog they need to be tagged with
peer.messaging.destinationacross each tracer. This does this for the Node tracerMotivation
mproved inferred services.
Plugin Checklist
Additional Notes