Skip to content

[DI] Align PII redaction tokens with the other tracers#5114

Merged
watson merged 1 commit into
masterfrom
watson/DEBUG-2745/align-with-other-langs
Jan 17, 2025
Merged

[DI] Align PII redaction tokens with the other tracers#5114
watson merged 1 commit into
masterfrom
watson/DEBUG-2745/align-with-other-langs

Conversation

@watson

@watson watson commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Remove a bunch of redaction tokens that we agreed shouldn't be redacted when collecting probe snapshots.

Depends on: DataDog/system-tests#3827

Motivation

Feature parity

Plugin Checklist

Additional Notes

@watson
watson requested review from a team as code owners January 15, 2025 14:37
@watson watson self-assigned this Jan 15, 2025
@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Jan 15, 2025

watson commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.4 MB
Deduped: 94.74 MB
No deduping: 95.26 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter

pr-commenter Bot commented Jan 15, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-15 14:48:23

Comparing candidate commit 094569e in PR branch watson/DEBUG-2745/align-with-other-langs with baseline commit 95f82a9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 879 metrics, 24 unstable metrics.

@watson
watson merged commit c37f47b into master Jan 17, 2025
@watson
watson deleted the watson/DEBUG-2745/align-with-other-langs branch January 17, 2025 13:14
@watson watson mentioned this pull request Jan 22, 2025
@watson watson mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants