Skip to content

[DI] Add missing PII redaction tokens#5112

Merged
watson merged 1 commit into
masterfrom
watson/DEBUG-2745/add-missing-pii-redactions
Jan 15, 2025
Merged

[DI] Add missing PII redaction tokens#5112
watson merged 1 commit into
masterfrom
watson/DEBUG-2745/add-missing-pii-redactions

Conversation

@watson

@watson watson commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Adds two extra PII redaction tokens that were missing according to the system tests.

Motivation

Plugin Checklist

Additional Notes

@watson
watson requested review from a team as code owners January 15, 2025 12:27
@watson watson self-assigned this Jan 15, 2025
@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Jan 15, 2025

watson commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.4 MB
Deduped: 94.74 MB
No deduping: 95.26 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Jan 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (149742b) to head (80074fc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5112      +/-   ##
==========================================
+ Coverage   61.24%   62.90%   +1.66%     
==========================================
  Files         289      163     -126     
  Lines       13586     5969    -7617     
==========================================
- Hits         8321     3755    -4566     
+ Misses       5265     2214    -3051     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@watson
watson enabled auto-merge (squash) January 15, 2025 12:37
@pr-commenter

pr-commenter Bot commented Jan 15, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-15 12:39:15

Comparing candidate commit 80074fc in PR branch watson/DEBUG-2745/add-missing-pii-redactions with baseline commit b070889 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 880 metrics, 23 unstable metrics.

@watson
watson merged commit ff07f4f into master Jan 15, 2025
@watson
watson deleted the watson/DEBUG-2745/add-missing-pii-redactions branch January 15, 2025 12:41
watson added a commit that referenced this pull request Jan 22, 2025
@watson watson mentioned this pull request Jan 22, 2025
watson added a commit that referenced this pull request Jan 22, 2025
@watson watson mentioned this pull request Jan 22, 2025
watson added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants