Skip to content

Use literals for creating BigInts when possible#5093

Merged
watson merged 1 commit into
masterfrom
watson/bigint-literal
Jan 13, 2025
Merged

Use literals for creating BigInts when possible#5093
watson merged 1 commit into
masterfrom
watson/bigint-literal

Conversation

@watson

@watson watson commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Change BigInt(42) to 42n

Motivation

#5081 (comment)

Plugin Checklist

Additional Notes

@watson
watson requested review from a team as code owners January 13, 2025 08:56
@watson watson self-assigned this Jan 13, 2025

watson commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.39 MB
Deduped: 94.73 MB
No deduping: 95.25 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson
watson enabled auto-merge (squash) January 13, 2025 08:59
@pr-commenter

pr-commenter Bot commented Jan 13, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-13 09:04:58

Comparing candidate commit 9fbc7b6 in PR branch watson/bigint-literal with baseline commit d73f8cb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 777 metrics, 21 unstable metrics.

@watson
watson merged commit f76beab into master Jan 13, 2025
@watson
watson deleted the watson/bigint-literal branch January 13, 2025 09:09
@watson watson mentioned this pull request Jan 22, 2025
@watson watson mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants