Skip to content

Log when setting priority on a noop span#5086

Merged
iunanua merged 1 commit into
masterfrom
igor/log-noop-spans
Jan 9, 2025
Merged

Log when setting priority on a noop span#5086
iunanua merged 1 commit into
masterfrom
igor/log-noop-spans

Conversation

@iunanua

@iunanua iunanua commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Log when setting priority on a noop span

Motivation

Plugin Checklist

Additional Notes

@github-actions

github-actions Bot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.44 MB
Deduped: 94.78 MB
No deduping: 95.3 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter

pr-commenter Bot commented Jan 9, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-09 11:44:36

Comparing candidate commit 8644b43 in PR branch igor/log-noop-spans with baseline commit 4b6a83a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 775 metrics, 23 unstable metrics.

@iunanua
iunanua marked this pull request as ready for review January 9, 2025 12:42
@iunanua
iunanua requested a review from a team as a code owner January 9, 2025 12:42
@iunanua
iunanua merged commit 98e733f into master Jan 9, 2025
@iunanua
iunanua deleted the igor/log-noop-spans branch January 9, 2025 14:16
@watson watson mentioned this pull request Jan 22, 2025
@watson watson mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants