Skip to content

DNS Lookup event hostname is sometimes not a string#5067

Merged
szegedi merged 2 commits into
masterfrom
szegedi/always-a-string
Jan 10, 2025
Merged

DNS Lookup event hostname is sometimes not a string#5067
szegedi merged 2 commits into
masterfrom
szegedi/always-a-string

Conversation

@szegedi

@szegedi szegedi commented Jan 3, 2025 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Ensures that values of event details we want to encode as labels are always coerced to string because sometimes they aren't strings. (Possibly: null or undefined?)

Motivation

A low cardinality occurrence of the following error in our telemetry logs:

Error : redacted
TypeError: redacted
    at labelFromStr (dd-trace/src/profiling/profilers/events.js:17:44)
    at addLabel (dd-trace/src/profiling/profilers/events.js:88:19)
    at DNSDecorator.decorateSample (dd-trace/src/profiling/profilers/events.js:95:9)
    at EventSerializer.addEvent (dd-trace/src/profiling/profilers/events.js:200:15)
    at DNSLookupPlugin.eventHandler (dd-trace/src/profiling/profilers/events.js:336:56)
    at DNSLookupPlugin.finish (dd-trace/src/profiling/profilers/event_plugins/event.js:54:10)
    ...

JIRA: PROF-11087

@szegedi
szegedi requested a review from a team as a code owner January 3, 2025 12:38
@github-actions

github-actions Bot commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.36 MB
Deduped: 94.71 MB
No deduping: 95.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

juan-fernandez
juan-fernandez previously approved these changes Jan 3, 2025
View reviewed changes
@pr-commenter

pr-commenter Bot commented Jan 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-10 10:38:37

Comparing candidate commit 56d7ccc in PR branch szegedi/always-a-string with baseline commit 12f2418 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 780 metrics, 16 unstable metrics.

scenario:log-skip-log-20

  • 🟥 cpu_user_time [+18.081ms; +22.736ms] or [+5.078%; +6.385%]

scenario:plugin-graphql-with-async-hooks-20

  • 🟥 max_rss_usage [+109.546MB; +111.734MB] or [+20.563%; +20.974%]

nsavoire
nsavoire previously approved these changes Jan 6, 2025
View reviewed changes
@szegedi
szegedi force-pushed the szegedi/always-a-string branch from 5b089cb to 56d7ccc Compare January 10, 2025 10:27
@szegedi
szegedi merged commit 7e4b054 into master Jan 10, 2025
@szegedi
szegedi deleted the szegedi/always-a-string branch January 10, 2025 13:49
watson pushed a commit that referenced this pull request Jan 22, 2025
@szegedi @watson
DNS Lookup event hostname is sometimes not a string (#5067)
7830278
@watson watson mentioned this pull request Jan 22, 2025
Closed
watson pushed a commit that referenced this pull request Jan 22, 2025
@szegedi @watson
DNS Lookup event hostname is sometimes not a string (#5067)
fea76b9
@watson watson mentioned this pull request Jan 22, 2025
Merged
watson pushed a commit that referenced this pull request Jan 23, 2025
@szegedi @watson
DNS Lookup event hostname is sometimes not a string (#5067)
dfddf05
@tlhunter tlhunter mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsavoire nsavoire nsavoire approved these changes
@juan-fernandez juan-fernandez juan-fernandez left review comments

Assignees

No one assigned

Labels

profiling semver-patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szegedi @nsavoire @juan-fernandez