refactor custom metrics to be self-contained#5061
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 8.41 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-12-31 05:42:50 Comparing candidate commit 8c89cf4 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 776 metrics, 21 unstable metrics. scenario:log-without-log-20
|
bengl
enabled auto-merge (squash)
January 3, 2025 14:08
uurien
reviewed
Jan 3, 2025
| const clientConfig = DogStatsDClient.generateClientConfig(config) | ||
| this.dogstatsd = new DogStatsDClient(clientConfig) | ||
|
|
||
| this._boundFlush = this.flush.bind(this) |
Contributor
There was a problem hiding this comment.
Why are _boundFlush and _flushInterval object level properties, and not just const boundFlush and const flushInterval?
rochdev
reviewed
Jan 7, 2025
BridgeAR
approved these changes
Feb 24, 2025
BridgeAR
left a comment
BridgeAR
left a comment
Member
There was a problem hiding this comment.
LGTM % comment. I would definitely prefer not to add any properties that are not absolutely needed
Comment on lines
+194
to
+200
| this._boundFlush = this.flush.bind(this) | ||
|
|
||
| // TODO(bengl) this magic number should be configurable | ||
| this._flushInterval = setInterval(this._boundFlush, 10 * 1000) | ||
| this._flushInterval.unref() | ||
|
|
||
| process.once('beforeExit', this._boundFlush) |
Member
There was a problem hiding this comment.
Suggested change
| this._boundFlush = this.flush.bind(this) | |
| // TODO(bengl) this magic number should be configurable | |
| this._flushInterval = setInterval(this._boundFlush, 10 * 1000) | |
| this._flushInterval.unref() | |
| process.once('beforeExit', this._boundFlush) | |
| const flush = this.flush.bind(this) | |
| // TODO(bengl) this magic number should be configurable | |
| setInterval(flush, 10 * 1000).unref() | |
| process.once('beforeExit', flush) |
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
Merged
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had no real business being in
Proxy#init(), so I moved it to where it makes more sense.