Automated Session Tracking#5060
Merged
Merged
Conversation
simon-id
marked this pull request as ready for review
February 24, 2025 08:30
IlyasShabi
reviewed
Feb 24, 2025
| return | ||
| } | ||
|
|
||
| const isSdkCalled = rootSpan.context()._tags['usr.session_id'] |
Contributor
There was a problem hiding this comment.
You can use USER_SESSION_ID
Contributor
Author
There was a problem hiding this comment.
no this is a tag, not an address, and we have hardcoded tags all around, we've never properly took the time to enum the tags used in appsec, not really a fan of doing it in this PR particularly
uurien
previously approved these changes
Feb 24, 2025
IlyasShabi
previously approved these changes
Feb 25, 2025
uurien
approved these changes
Feb 26, 2025
Merged
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
watson
pushed a commit
that referenced
this pull request
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds instrumentation for
express-sessionto get sessionIDs, send them to the WAF, feed them into our fingerprinting algorithm, and potentially block bad actors.ST PR: DataDog/system-tests#3755