[DI] Implement PII redaction#5053
Merged
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Overall package sizeSelf size: 8.44 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2025-01-08 07:32:19 Comparing candidate commit 3936cee in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 774 metrics, 22 unstable metrics. scenario:log-without-log-20
|
juan-fernandez
previously approved these changes
Jan 2, 2025
watson
force-pushed
the
watson/DEBUG-2630/add-redaction
branch
from
January 6, 2025 11:34
ac6401b to
883b932
Compare
juan-fernandez
previously approved these changes
Jan 7, 2025
6 tasks
watson
enabled auto-merge (squash)
January 8, 2025 05:07
The algorithm will look for:
- names of variables
- names of object properties
- names of keys in maps
The names will be matched against a disallow-list and if a match is
found, its value will be redacted.
The list is hardcoded and can be found here:
packages/dd-trace/src/debugger/devtools_client/snapshot/redaction.js
It's possible to add names to the list using the following environment
variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTED_IDENTIFIERS
Or it's possble to remove names from the list using the following
environment variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS
Each environment variable takes a list of names separated by commas.
Support for redacting instances of specific classes is not included in
this commit.
watson
force-pushed
the
watson/DEBUG-2630/add-redaction
branch
from
January 8, 2025 05:34
37c329a to
32b1c34
Compare
6 tasks
juan-fernandez
approved these changes
Jan 8, 2025
watson
added a commit
that referenced
this pull request
Jan 22, 2025
The algorithm will look for:
- names of variables
- names of object properties
- names of keys in maps
The names will be matched against a disallow-list and if a match is
found, its value will be redacted.
The list is hardcoded and can be found here:
packages/dd-trace/src/debugger/devtools_client/snapshot/redaction.js
It's possible to add names to the list using the following environment
variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTED_IDENTIFIERS
Or it's possible to remove names from the list using the following
environment variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS
Each environment variable takes a list of names separated by commas.
Support for redacting instances of specific classes is not included in
this commit.
Closed
watson
added a commit
that referenced
this pull request
Jan 22, 2025
The algorithm will look for:
- names of variables
- names of object properties
- names of keys in maps
The names will be matched against a disallow-list and if a match is
found, its value will be redacted.
The list is hardcoded and can be found here:
packages/dd-trace/src/debugger/devtools_client/snapshot/redaction.js
It's possible to add names to the list using the following environment
variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTED_IDENTIFIERS
Or it's possible to remove names from the list using the following
environment variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS
Each environment variable takes a list of names separated by commas.
Support for redacting instances of specific classes is not included in
this commit.
Merged
watson
added a commit
that referenced
this pull request
Jan 23, 2025
The algorithm will look for:
- names of variables
- names of object properties
- names of keys in maps
The names will be matched against a disallow-list and if a match is
found, its value will be redacted.
The list is hardcoded and can be found here:
packages/dd-trace/src/debugger/devtools_client/snapshot/redaction.js
It's possible to add names to the list using the following environment
variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTED_IDENTIFIERS
Or it's possible to remove names from the list using the following
environment variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS
Each environment variable takes a list of names separated by commas.
Support for redacting instances of specific classes is not included in
this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm will look for:
The names will be matched against a disallow-list and if a match is found, its value will be redacted.
The list is hardcoded and can be found here:
It's possible to add names to the list using the following environment variable:
Or it's possble to remove names from the list using the following environment variable:
Each environment variable takes a list of names separated by commas.
Support for redacting instances of specific classes is not included in this PR.
Blocked by