Skip to content

Remove x-forwarded from ipHeaderList#4882

Merged
simon-id merged 3 commits intomasterfrom
appsec_stop_collecting_x-forwarded
Nov 14, 2024
Merged

Remove x-forwarded from ipHeaderList#4882
simon-id merged 3 commits intomasterfrom
appsec_stop_collecting_x-forwarded

Conversation

@simon-id
Copy link
Copy Markdown
Member

@simon-id simon-id commented Nov 13, 2024

What does this PR do?

Remove the x-forwarded header from the IP collection list, but keep it in the tags collection.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 13, 2024

Overall package size

Self size: 7.98 MB
Deduped: 94.27 MB
No deduping: 94.61 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-13 21:51:08

Comparing candidate commit 2df605e in PR branch appsec_stop_collecting_x-forwarded with baseline commit 83e11a3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@simon-id simon-id marked this pull request as ready for review November 13, 2024 21:50
@simon-id simon-id requested review from a team as code owners November 13, 2024 21:50
@simon-id simon-id merged commit 9146f26 into master Nov 14, 2024
@simon-id simon-id deleted the appsec_stop_collecting_x-forwarded branch November 14, 2024 08:09
rochdev pushed a commit that referenced this pull request Nov 14, 2024
@rochdev rochdev mentioned this pull request Nov 14, 2024
rochdev pushed a commit that referenced this pull request Nov 14, 2024
@rochdev rochdev mentioned this pull request Nov 14, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants