Skip to content

add client configuration of trace analytics#469

Merged
rochdev merged 2 commits into
v0.10.0from
analytics-sampling
Mar 6, 2019
Merged

add client configuration of trace analytics#469
rochdev merged 2 commits into
v0.10.0from
analytics-sampling

Conversation

@rochdev

@rochdev rochdev commented Feb 27, 2019

Copy link
Copy Markdown
Member

This PR adds client configuration of Trace Analytics with the following options:

  • Option on the tracer to globally enable/disable Trace Analytics.
  • Option on every plugin to enable/disable Trace Analytics and set the default sample rate for the plugin or rate per operation name.
  • Option on tracer.trace() to enable/disable Trace Analytics or set a specific sample rate.
  • Tag that can be set on the span to set the sample rate.

Comment thread src/format.js
Comment thread src/instrumenter.js

@brettlangdon brettlangdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test case showing we only inherit from the global config for web frameworks only?

@rochdev

rochdev commented Mar 6, 2019

Copy link
Copy Markdown
Member Author

It would be redundant since it would just be to copy the true or false value from the code to the test.

@rochdev
rochdev merged commit 17d4faf into v0.10.0 Mar 6, 2019
@rochdev
rochdev deleted the analytics-sampling branch March 6, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants