Re-enable telemetry logs#4079
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 6.08 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
==========================================
- Coverage 85.33% 84.98% -0.35%
==========================================
Files 243 247 +4
Lines 10569 10730 +161
Branches 33 33
==========================================
+ Hits 9019 9119 +100
- Misses 1550 1611 +61 ☔ View full report in Codecov by Sentry. |
iunanua
marked this pull request as ready for review
February 20, 2024 13:28
simon-id
approved these changes
Feb 20, 2024
iunanua
enabled auto-merge (squash)
February 20, 2024 14:54
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-enable telemetry logs module used by the IAST
It includes a test in the IAST namespace so that the @DataDog/asm-js team is notified if any modification of the expected behavior is made in the future.
Motivation
The migration to telemetry v2 left out the telemetry logs module #3827.
Plugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!