fixing the eu endpoint for agentless telemetry#4067
Merged
Conversation
Contributor
Overall package sizeSelf size: 6.04 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4067 +/- ##
=======================================
Coverage 85.34% 85.35%
=======================================
Files 243 243
Lines 10576 10574 -2
Branches 33 33
=======================================
- Hits 9026 9025 -1
+ Misses 1550 1549 -1 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-15 14:12:26 Comparing candidate commit 8a67a34 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-on-max-18
|
simon-id
approved these changes
Feb 15, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 19, 2024
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with dd-trace where the agentless-telemetry was not pointing to the correct domain for the eu site.
currently it is pointing to https://instrumentation-telemetry-intake.eu1.datadoghq.com
it should be pointing to https://instrumentation-telemetry-intake.datadoghq.eu
I used the documentation here to address this issue:
https://github.com/DataDog/instrumentation-telemetry-api-docs/blob/main/GeneratedDocumentation/ApiDocs/v2/development.md#agentless
Motivation
A trial customer was facing an issue implementing agentless telemetry in their application due to this issue.
Plugin Checklist
I updated a unit test.
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!