Skip to content

add APM_TRACING_ENABLED capability for remote config#4065

Merged
ida613 merged 2 commits into
masterfrom
ida613/apm_uninstrumentation_patch
Feb 16, 2024
Merged

add APM_TRACING_ENABLED capability for remote config#4065
ida613 merged 2 commits into
masterfrom
ida613/apm_uninstrumentation_patch

Conversation

@ida613

@ida613 ida613 commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ida613
ida613 requested a review from a team as a code owner February 15, 2024 04:40
@ida613
ida613 marked this pull request as draft February 15, 2024 04:40
@github-actions

github-actions Bot commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.04 MB
Deduped: 61.64 MB
No deduping: 62.4 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f8d0a) 85.33% compared to head (bf80b60) 85.35%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4065      +/-   ##
==========================================
+ Coverage   85.33%   85.35%   +0.01%     
==========================================
  Files         243      243              
  Lines       10570    10575       +5     
  Branches       33       33              
==========================================
+ Hits         9020     9026       +6     
+ Misses       1550     1549       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter

pr-commenter Bot commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-02-15 16:29:41

Comparing candidate commit bf80b60 in PR branch ida613/apm_uninstrumentation_patch with baseline commit 22f8d0a in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 8 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-113.654MB; -99.102MB] or [-12.073%; -10.528%]

Kyle-Verhoog
Kyle-Verhoog reviewed Feb 15, 2024
View reviewed changes
Comment thread packages/dd-trace/src/appsec/remote_config/capabilities.js Outdated
simon-id
simon-id reviewed Feb 16, 2024
View reviewed changes

@simon-id simon-id left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ida613
ida613 marked this pull request as ready for review February 16, 2024 15:46
@ida613
ida613 merged commit 575bff5 into master Feb 16, 2024
@ida613
ida613 deleted the ida613/apm_uninstrumentation_patch branch February 16, 2024 17:05
CarlesDD pushed a commit that referenced this pull request Feb 19, 2024
@ida613 @CarlesDD
add APM_TRACING_ENABLED capability for remote config (#4065)
61733d3
@CarlesDD CarlesDD mentioned this pull request Feb 19, 2024
Merged
CarlesDD pushed a commit that referenced this pull request Feb 20, 2024
@ida613 @CarlesDD
add APM_TRACING_ENABLED capability for remote config (#4065)
b9d653e
@CarlesDD CarlesDD mentioned this pull request Feb 20, 2024
Merged
CarlesDD pushed a commit that referenced this pull request Feb 20, 2024
@ida613 @CarlesDD
add APM_TRACING_ENABLED capability for remote config (#4065)
b46c36d
@CarlesDD CarlesDD mentioned this pull request Feb 20, 2024
Merged
CarlesDD pushed a commit that referenced this pull request Feb 22, 2024
@ida613 @CarlesDD
add APM_TRACING_ENABLED capability for remote config (#4065)
f863e3f
CarlesDD pushed a commit that referenced this pull request Feb 22, 2024
@ida613 @CarlesDD
add APM_TRACING_ENABLED capability for remote config (#4065)
b407c60
CarlesDD pushed a commit that referenced this pull request Feb 22, 2024
@ida613 @CarlesDD
add APM_TRACING_ENABLED capability for remote config (#4065)
d2f66c6
@erikvanbrakel erikvanbrakel mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog left review comments
@rochdev rochdev rochdev approved these changes
+1 more reviewer
@simon-id simon-id simon-id approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ida613 @rochdev @Kyle-Verhoog @simon-id