[ci-visibility] Early flake detection for mocha #4060
Merged
juan-fernandez merged 5 commits intoFeb 19, 2024
Merged
Conversation
Contributor
Overall package sizeSelf size: 6.05 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4060 +/- ##
==========================================
- Coverage 85.34% 84.87% -0.48%
==========================================
Files 243 243
Lines 10576 10636 +60
Branches 33 33
==========================================
+ Hits 9026 9027 +1
- Misses 1550 1609 +59 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-15 16:08:08 Comparing candidate commit dcc1476 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 4 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
|
juan-fernandez
force-pushed
the
juan-fernandez/early-flake-detection-mocha
branch
from
February 15, 2024 11:06
26a0ca9 to
5dc304d
Compare
juan-fernandez
commented
Feb 15, 2024
| }) | ||
| }) | ||
| }) | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
ℹ️ these tests were not removed, just moved from running exclusively for jest to run also for mocha. The tests themselves changed very little
juan-fernandez
commented
Feb 15, 2024
| // only run for jest tests | ||
| if (typeof jest !== 'undefined') { | ||
| it.todo('todo will not be retried') | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
ℹ️ it.todo is not supported in mocha
juan-fernandez
commented
Feb 15, 2024
| } | ||
|
|
||
| function getFailingNewTests (root) { | ||
| let failingTests = [] |
Collaborator
Author
There was a problem hiding this comment.
TODO: if every attempt fails, we should still fail. It's just if it's flaky that we want non to block
juan-fernandez
commented
Feb 15, 2024
| asyncResource.runInAsyncScope(() => { | ||
| testStartCh.publish({ | ||
| name: removeEfdTestName(testName), | ||
| name: removeEfdStringFromTestName(testName), |
Collaborator
Author
There was a problem hiding this comment.
unrelated improvements in this file
romainkomorn-exdatadog
approved these changes
Feb 16, 2024
rochdev
approved these changes
Feb 16, 2024
juan-fernandez
deleted the
juan-fernandez/early-flake-detection-mocha
branch
February 19, 2024 07:54
CarlesDD
pushed a commit
that referenced
this pull request
Feb 19, 2024
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
Merged
CarlesDD
pushed a commit
that referenced
this pull request
Feb 20, 2024
Merged
3 tasks
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
CarlesDD
pushed a commit
that referenced
this pull request
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mochaRunner.prototype.runTests, we check which ones are new and duplicate them.ℹ️ Most of the lines changed are because I moved tests around, but the actual tests look almost identical.
Motivation
Implement early flake detection for
mocha.Plugin Checklist
Security
Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!