[ci-visibility] Remove usage of application key for intelligent test runner#3660
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.22 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3660 +/- ##
==========================================
+ Coverage 84.77% 84.80% +0.02%
==========================================
Files 219 219
Lines 8961 8949 -12
Branches 33 33
==========================================
- Hits 7597 7589 -8
+ Misses 1364 1360 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-09-27 12:44:33 Comparing candidate commit 06194f4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 384 metrics, 8 unstable metrics. |
juan-fernandez
force-pushed
the
juan-fernandez/remove-app-key-usage
branch
from
September 27, 2023 12:30
4482dd3 to
06194f4
Compare
tonyredondo
approved these changes
Sep 27, 2023
juan-fernandez
marked this pull request as ready for review
September 27, 2023 12:47
szegedi
approved these changes
Sep 27, 2023
Comment on lines
-139
to
+137
| delete process.env.DD_APP_KEY | ||
| delete process.env.DD_API_KEY |
Contributor
There was a problem hiding this comment.
I guess this was an oversight before that API key wasn't deleted?
Collaborator
Author
There was a problem hiding this comment.
well I was testing the failure of the ITR settings request, which failed as long as any app or api key were missing. Removing app key then was enough
juan-fernandez
changed the title
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove application key usage from ci visibility.
Motivation
Application key is no longer needed for ITR related requests.