core: Fix Next.js App Router Resource Name#3648
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.21 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3648 +/- ##
==========================================
+ Coverage 84.78% 87.95% +3.16%
==========================================
Files 219 215 -4
Lines 8961 8540 -421
Branches 33 33
==========================================
- Hits 7598 7511 -87
+ Misses 1363 1029 -334
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sabrenner
added
the
integration-nextjs
sabrenner
marked this pull request as ready for review
September 20, 2023 16:58
tlhunter
approved these changes
Sep 20, 2023
Merged
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes resource names for
approuter projects. Previously, trying to hit an API endpoint would end the resource with/route(ie/api/hello/world/route), and likewise for pages would end with/page. This PR removes those endings.Additionally, this PR addresses a small issue that was brought up in Next.js 13.5.1 and possibly backported to 13.4.19, where a variable on an object we were inspecting to get the resource path group from changed from
pathnametopage.Motivation
Further the solidification of support for Next.js, especially since the App Router has been out of beta and is the recommended configuration for all Next.js projects since versions 13.4.x.