[ci-visibility] Fix playwright latest release#3646
Merged
juan-fernandez merged 1 commit intoSep 20, 2023
Conversation
Contributor
Overall package sizeSelf size: 5.2 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3646 +/- ##
==========================================
- Coverage 84.78% 84.78% -0.01%
==========================================
Files 219 219
Lines 8961 8962 +1
Branches 33 33
==========================================
Hits 7598 7598
- Misses 1363 1364 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-09-20 12:56:25 Comparing candidate commit 53959d0 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 428 metrics, 21 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
simon-id
approved these changes
Sep 20, 2023
nikita-tkachenko-datadog
approved these changes
Sep 20, 2023
juan-fernandez
deleted the
juan-fernandez/fix-playwright-latest-release
branch
September 20, 2023 14:10
Merged
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There was some internal reorg of the packages in the repository and this broke our instrumentation.
Motivation
Fixes #3639
Fix v1.38.0 playwright release.
Tests are now passing: https://github.com/DataDog/dd-trace-js/actions/runs/6248770201/job/16964070478?pr=3646 (they weren't before)