Fix DBM service#3634
Conversation
Overall package sizeSelf size: 5.21 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3634 +/- ##
==========================================
- Coverage 84.78% 84.78% -0.01%
==========================================
Files 219 219
Lines 8961 8960 -1
Branches 33 33
==========================================
- Hits 7598 7597 -1
Misses 1363 1363
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-09-15 14:49:46 Comparing candidate commit 1bb3a0ea2ad069506d6a739c1a091fe34dcd2364 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 433 metrics, 16 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
jbertran
added
bug
c32cf4b to
8e2a1e5
Compare
e064735 to
1bb3a0e
Compare
There was a problem hiding this comment.
This used to always call done but now it only calls done if there is an error. Does this change mean the previous behavior was incorrect?
There was a problem hiding this comment.
Yes - we're done once the agent.use called by withPeerService is done, not before. IIRC this was causing some 'done called twice' output even in successful tests.
There was a problem hiding this comment.
I'm surprised the unused done didn't throw a linter error before
There was a problem hiding this comment.
Indeed. I tried finding where in eslint this would trip up, no-unused-vars's doc seems to suggest it should, but it doesn't...
1bb3a0e to
2bd4ca4
Compare
* use peer service in DBM dddbs value if available * switch to _tracerConfig for peer service config * fix amqplib plugin load order in tests * abort plugin load when tracer is uninitialized
* use peer service in DBM dddbs value if available * switch to _tracerConfig for peer service config * fix amqplib plugin load order in tests * abort plugin load when tracer is uninitialized
* use peer service in DBM dddbs value if available * switch to _tracerConfig for peer service config * fix amqplib plugin load order in tests * abort plugin load when tracer is uninitialized
* use peer service in DBM dddbs value if available * switch to _tracerConfig for peer service config * fix amqplib plugin load order in tests * abort plugin load when tracer is uninitialized
2 participants
What does this PR do?
Use peer service if available for DBM service computation. This repairs DBM issues that stem from the v1 naming schema.
Notes
As a drive-by, I simplified to
_tracerConfigfor all configuration access. There's no need to keep this at the tracer level.Plugin Checklist
Additional Notes