core: Next.js Tracing More In-line with OTel Tracing#3632
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.2 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3632 +/- ##
==========================================
+ Coverage 84.62% 84.78% +0.16%
==========================================
Files 217 219 +2
Lines 8786 8961 +175
Branches 33 33
==========================================
+ Hits 7435 7598 +163
- Misses 1351 1363 +12 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-09-19 13:56:30 Comparing candidate commit 41bf32e in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 427 metrics, 22 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
tlhunter
reviewed
Sep 13, 2023
sabrenner
added
the
integration-nextjs
Qard
approved these changes
Sep 19, 2023
Merged
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
* removing tracing from non-otel spots * rmv abs path from static resource name * add TODO comment * add serve static hook for older versions * hopefully fix some ESM stuff * fixes for hooks test and static resource names * remove esm changes and .gitignore change * fix esm issues * clean up esm
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
* removing tracing from non-otel spots * rmv abs path from static resource name * add TODO comment * add serve static hook for older versions * hopefully fix some ESM stuff * fixes for hooks test and static resource names * remove esm changes and .gitignore change * fix esm issues * clean up esm
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
* removing tracing from non-otel spots * rmv abs path from static resource name * add TODO comment * add serve static hook for older versions * hopefully fix some ESM stuff * fixes for hooks test and static resource names * remove esm changes and .gitignore change * fix esm issues * clean up esm
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
* removing tracing from non-otel spots * rmv abs path from static resource name * add TODO comment * add serve static hook for older versions * hopefully fix some ESM stuff * fixes for hooks test and static resource names * remove esm changes and .gitignore change * fix esm issues * clean up esm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes sure the tracing is more in-line with how Next.js internally uses OTel to trace some of their functions by removing recently-added wrappers for functions that do not actually need to be traced. Instead, simpler wrappers are added in some cases, and the instrumentation used before is kept as it is more closely aligned with how Next.js uses OTel to start spans for certain functions.
Motivation
TODOto either instrument all or none of the render functions.next.requextspans should only appear once in a trace, and thus should not execute hooks more than once. A test for this is added as well.