Skip to content

Update waf bindings 4.0.0 (libddwaf 1.14.0)#3620

Merged
iunanua merged 6 commits into
masterfrom
igor/update-waf-bindings-4.0.0
Sep 15, 2023
Merged

Update waf bindings 4.0.0 (libddwaf 1.14.0)#3620
iunanua merged 6 commits into
masterfrom
igor/update-waf-bindings-4.0.0

Conversation

@iunanua

@iunanua iunanua commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Updates the @datadog/native-appsec dependency version to 4.0.0 and adapts the code to the changes required by the new version.
  • Includes the ASM_TRUSTED_IPS capability

@github-actions

github-actions Bot commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 5.17 MB
Deduped: 60.66 MB
No deduping: 60.83 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 4.0.0 14.83 MB 14.83 MB
@datadog/pprof 3.2.0 10.8 MB 11.64 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.1.3 2.23 MB 2.32 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3620 (29cd3a3) into master (28d21b1) will decrease coverage by 0.15%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3620      +/-   ##
==========================================
- Coverage   84.70%   84.55%   -0.15%     
==========================================
  Files         219      217       -2     
  Lines        8948     8777     -171     
  Branches       33       33              
==========================================
- Hits         7579     7421     -158     
+ Misses       1369     1356      -13
Files Changed Coverage Δ
.../dd-trace/src/appsec/remote_config/capabilities.js 100.00% <ø> (ø)
...ackages/dd-trace/src/appsec/remote_config/index.js 100.00% <100.00%> (ø)
packages/dd-trace/src/appsec/reporter.js 100.00% <100.00%> (ø)
packages/dd-trace/src/appsec/telemetry.js 100.00% <100.00%> (ø)
...ges/dd-trace/src/appsec/waf/waf_context_wrapper.js 92.85% <100.00%> (ø)
packages/dd-trace/src/appsec/waf/waf_manager.js 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter

pr-commenter Bot commented Sep 8, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-09-11 14:04:47

Comparing candidate commit 29cd3a3 in PR branch igor/update-waf-bindings-4.0.0 with baseline commit 28d21b1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 473 metrics, 19 unstable metrics.

@iunanua
iunanua marked this pull request as ready for review September 11, 2023 07:37
@iunanua
iunanua requested review from a team as code owners September 11, 2023 07:37
simon-id
simon-id reviewed Sep 11, 2023
View reviewed changes
Comment thread packages/dd-trace/src/appsec/waf/waf_context_wrapper.js
simon-id
simon-id reviewed Sep 11, 2023
View reviewed changes
Comment thread packages/dd-trace/src/appsec/waf/waf_context_wrapper.js
simon-id
simon-id reviewed Sep 11, 2023
View reviewed changes
Comment thread packages/dd-trace/test/appsec/rule_manager.spec.js
@iunanua
iunanua force-pushed the igor/update-waf-bindings-4.0.0 branch from 3338f20 to 10bff10 Compare September 11, 2023 10:16
simon-id
simon-id reviewed Sep 11, 2023
View reviewed changes
Comment thread packages/dd-trace/test/appsec/waf/index.spec.js Outdated
simon-id
simon-id previously approved these changes Sep 11, 2023
View reviewed changes
@iunanua iunanua changed the title Update waf bindings 4.0.0 Update waf bindings 4.0.0 (libddwaf 1.14.0) Sep 12, 2023
@iunanua
iunanua merged commit 8f145bf into master Sep 15, 2023
@khanayan123 khanayan123 mentioned this pull request Sep 26, 2023
Merged
@khanayan123 khanayan123 mentioned this pull request Sep 26, 2023
Merged
khanayan123 pushed a commit that referenced this pull request Sep 26, 2023
@iunanua @simon-id @khanayan123
Update waf bindings 4.0.0 (libddwaf 1.14.0) (#3620)
effe7bf 
* Update libddwaf related code

* Add the ASM_TRUSTED_IPS capability

---------

Co-authored-by: simon-id <[email protected]>
khanayan123 pushed a commit that referenced this pull request Sep 26, 2023
@iunanua @simon-id @khanayan123
Update waf bindings 4.0.0 (libddwaf 1.14.0) (#3620)
05e8749 
* Update libddwaf related code

* Add the ASM_TRUSTED_IPS capability

---------

Co-authored-by: simon-id <[email protected]>
khanayan123 pushed a commit that referenced this pull request Sep 27, 2023
@iunanua @simon-id @khanayan123
Update waf bindings 4.0.0 (libddwaf 1.14.0) (#3620)
ff5fb30 
* Update libddwaf related code

* Add the ASM_TRUSTED_IPS capability

---------

Co-authored-by: simon-id <[email protected]>
khanayan123 pushed a commit that referenced this pull request Sep 27, 2023
@iunanua @simon-id @khanayan123
Update waf bindings 4.0.0 (libddwaf 1.14.0) (#3620)
d7ed91e 
* Update libddwaf related code

* Add the ASM_TRUSTED_IPS capability

---------

Co-authored-by: simon-id <[email protected]>
@iunanua
iunanua deleted the igor/update-waf-bindings-4.0.0 branch December 19, 2023 08:22
@erikvanbrakel erikvanbrakel mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@simon-id simon-id simon-id approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

asm-waf semver-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iunanua @simon-id