add support for graphql-yoga v3 executor#3610
Conversation
Overall package sizeSelf size: 5.22 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
272f485 to
48ab03e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 219 219
Lines 8961 8961
Branches 33 33
=======================================
Hits 7597 7597
Misses 1364 1364 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-09-22 21:04:54 Comparing candidate commit 4242517 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 380 metrics, 12 unstable metrics. |
|
the presence of graphql@^15.2.0 in versions causes the apollo core test to fail |
| 'node:fs': () => require('../fs'), | ||
| 'generic-pool': () => require('../generic-pool'), | ||
| 'graphql': () => require('../graphql'), | ||
| '@graphql-tools/executor': () => require('../graphql'), |
There was a problem hiding this comment.
Let's organize this alphabetically to make it easier to read.
| }) | ||
| } | ||
|
|
||
| addHook({ name: '@graphql-tools/executor', file: 'cjs/execution/execute.js', versions: ['>=0.0.14'] }, execute => { |
There was a problem hiding this comment.
Does this mean that ESM is not supported?
There was a problem hiding this comment.
Haven't tested it with ESM yet. But this is more of a feature request to support graphql-yoga v3 #2884 which uses @graphlql-tools/executor as it's executor rather the the graphql executor
| return agent.load('graphql') | ||
| .then(() => { | ||
| // graphql-yoga@^3.6.0 requires graphql@>=15.2.0 | ||
| if (semver.satisfies(version, '>=15.2.0')) { |
There was a problem hiding this comment.
Any way to add this without that many changes to the file?
3014b37 to
3cb75df
Compare
There was a problem hiding this comment.
Can you elaborate on this test removal more? At first glance it looks like this PR breaks support for apollo-server-core.
There was a problem hiding this comment.
Let's also call .skip on the test instead of commenting it out.
There was a problem hiding this comment.
The precense of graphql@^15.2.0 in the /versions folder causes [email protected]
to break in the before() hook. This test tests a library version that had its release occur 5 years ago &
updating the test would require using newer version of apollo-core which have a completely different syntax
and produces traces that are different then what is expected by this test
a6aef7c to
1e1771c
Compare
5398b01 to
fdab068
Compare
* add support for graphql-yoga v3 executor
* add support for graphql-yoga v3 executor
* add support for graphql-yoga v3 executor
* add support for graphql-yoga v3 executor
4 participants
What does this PR do?
adds support for graphql-yoga v3 executor
Motivation
customer request: #2884
Additional Notes
it was a bit challenging to figure out which v3 version of graphql-yoga added @graphql-tools/executor for execution. Upon testing it seems like it was added with 3.6.0^ minor release