fix errors from object shape of pg query being altered#3603
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.13 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3603 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 218 218
Lines 8880 8880
Branches 33 33
=======================================
Hits 7498 7498
Misses 1382 1382 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
simon-id
approved these changes
Aug 31, 2023
simon-id
reviewed
Aug 31, 2023
simon-id
left a comment
simon-id
left a comment
Contributor
There was a problem hiding this comment.
LGTM except:
- No tests ?
- I don't see the
if that cannot be done safely, it skips on DSM to avoid potential errors.part. Is that just implicit behavior from your changes ?
Member
Author
We should always do things safely regardless of tests, as these tests would be very complex to set up.
Yes, now it always patches safely or bails regardless of DSM. |
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix errors from object shape of pg query being altered.
Motivation
There were fix attempts in #3212 and #3307 but there were still issues since a new object was returned. The new approach instead attempts to alter the existing object, and if that cannot be done safely, it skips on DSM to avoid potential errors.