format peerServiceMapping of config object before emitting telemetry configuration payload#3566
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.17 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
===========================================
- Coverage 84.70% 68.32% -16.38%
===========================================
Files 219 213 -6
Lines 8948 8476 -472
Branches 33 33
===========================================
- Hits 7579 5791 -1788
- Misses 1369 2685 +1316
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-09-11 20:22:23 Comparing candidate commit b26f8db in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 470 metrics, 22 unstable metrics. |
sabrenner
force-pushed
the
conti/add-missing-telemetry-configurations
branch
from
August 28, 2023 17:34
85d15c5 to
73a0f3b
Compare
rochdev
requested changes
Aug 30, 2023
wconti27
changed the title
wconti27
changed the title
rochdev
reviewed
Sep 8, 2023
rochdev
left a comment
rochdev
left a comment
Member
There was a problem hiding this comment.
There should be a test for the new behaviour.
rochdev
approved these changes
Sep 12, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
…configuration payload (#3566) * rework telemetry configuration event to format config object before and correctly emit peerServiceMapping for intake
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
…configuration payload (#3566) * rework telemetry configuration event to format config object before and correctly emit peerServiceMapping for intake
Merged
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
…configuration payload (#3566) * rework telemetry configuration event to format config object before and correctly emit peerServiceMapping for intake
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
…configuration payload (#3566) * rework telemetry configuration event to format config object before and correctly emit peerServiceMapping for intake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds a function that is used to format the tracer configuration object
peerServiceMappingattribute from a map to a string map. This is necessary for telemetry intake to accept the configuration key and value.Why this PR is needed:
The current way that NodeJS Telemetry flattens the tracer config object results in the current
peerServiceMappingobject being flattened as well, and therefore blocked at telemetry intake.Additional Notes