Skip to content

upgrade instrumentation telemetry from v1 to v2#3328

Closed
crysmags wants to merge 46 commits into
masterfrom
inTelHeaders
Closed

upgrade instrumentation telemetry from v1 to v2#3328
crysmags wants to merge 46 commits into
masterfrom
inTelHeaders

Conversation

@crysmags

@crysmags crysmags commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR is to add required headers for v2 of instrumentation telemetry. This is Required headers doc.
To note, content length and container id headers are currently being handled in the request file, exporters/common/request.js

Motivation

Plugin Checklist

Additional Notes

@crysmags
crysmags requested a review from a team as a code owner June 30, 2023 17:48
@github-actions

github-actions Bot commented Jun 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 5.62 MB
Deduped: 61.61 MB
No deduping: 62.37 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 5.0.0 15.16 MB 15.17 MB
@datadog/pprof 4.0.1 9.32 MB 10.16 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.2.1 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Jun 30, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f4acb0) 85.10% compared to head (c603a8b) 51.33%.

❗ Current head c603a8b differs from pull request most recent head 18b69b2. Consider uploading reports for the commit 18b69b2 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3328       +/-   ##
===========================================
- Coverage   85.10%   51.33%   -33.78%     
===========================================
  Files         228       87      -141     
  Lines        9359     2848     -6511     
  Branches       33       33               
===========================================
- Hits         7965     1462     -6503     
+ Misses       1394     1386        -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crysmags crysmags closed this Jun 30, 2023
@crysmags crysmags reopened this Jul 5, 2023
Qard
Qard previously approved these changes Jul 6, 2023
View reviewed changes
@pr-commenter

pr-commenter Bot commented Aug 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-11-27 15:09:55

Comparing candidate commit 18b69b2 in PR branch inTelHeaders with baseline commit 9f4acb0 in branch master.

Found 187 performance improvements and 4 performance regressions! Performance is the same for 311 metrics, 10 unstable metrics.

scenario:appsec-appsec-enabled-16

  • 🟩 cpu_usage_percentage [-11.453%; -8.163%]
  • 🟩 cpu_user_time [-166.703ms; -160.025ms] or [-39.313%; -37.738%]
  • 🟩 execution_time [-155.256ms; -135.755ms] or [-31.065%; -27.163%]
  • 🟩 instructions [-397.1M instructions; -396.0M instructions] or [-37.252%; -37.152%]
  • 🟩 max_rss_usage [-8.063MB; -7.996MB] or [-13.016%; -12.907%]

scenario:appsec-appsec-enabled-18

  • 🟩 cpu_usage_percentage [-9.637%; -6.086%]
  • 🟩 cpu_user_time [-147.941ms; -140.528ms] or [-35.793%; -33.999%]
  • 🟩 execution_time [-144.305ms; -122.215ms] or [-29.248%; -24.771%]
  • 🟩 instructions [-375.4M instructions; -373.4M instructions] or [-35.499%; -35.312%]
  • 🟩 max_rss_usage [-9.082MB; -8.956MB] or [-12.272%; -12.102%]

scenario:appsec-appsec-enabled-with-attacks-16

  • 🟩 cpu_usage_percentage [-12.201%; -9.149%]
  • 🟩 cpu_user_time [-198.187ms; -191.092ms] or [-43.575%; -42.015%]
  • 🟩 execution_time [-185.236ms; -166.233ms] or [-35.004%; -31.413%]
  • 🟩 instructions [-491.7M instructions; -490.3M instructions] or [-42.337%; -42.220%]
  • 🟩 max_rss_usage [-9.901MB; -9.819MB] or [-15.522%; -15.393%]

scenario:appsec-appsec-enabled-with-attacks-18

  • 🟩 cpu_usage_percentage [-10.126%; -6.697%]
  • 🟩 cpu_user_time [-185.091ms; -177.620ms] or [-41.307%; -39.639%]
  • 🟩 execution_time [-178.583ms; -156.546ms] or [-34.032%; -29.832%]
  • 🟩 instructions [-465.3M instructions; -463.1M instructions] or [-40.532%; -40.345%]
  • 🟩 max_rss_usage [-10.714MB; -10.577MB] or [-14.172%; -13.990%]

scenario:appsec-control-16

  • 🟩 cpu_usage_percentage [-9.179%; -5.391%]
  • 🟩 cpu_user_time [-94.126ms; -86.721ms] or [-25.715%; -23.692%]
  • 🟩 execution_time [-85.357ms; -63.748ms] or [-19.250%; -14.376%]
  • 🟩 instructions [-157.8M instructions; -156.5M instructions] or [-19.084%; -18.923%]

scenario:appsec-control-18

  • 🟩 cpu_user_time [-68.980ms; -61.318ms] or [-19.699%; -17.511%]
  • 🟩 execution_time [-71.992ms; -49.007ms] or [-16.662%; -11.342%]
  • 🟩 instructions [-139.2M instructions; -136.8M instructions] or [-16.944%; -16.646%]

scenario:appsec-control-with-attacks-16

  • 🟩 cpu_usage_percentage [-9.844%; -6.421%]
  • 🟩 cpu_user_time [-91.167ms; -84.625ms] or [-26.268%; -24.383%]
  • 🟩 execution_time [-78.738ms; -59.828ms] or [-18.575%; -14.114%]
  • 🟩 instructions [-164.2M instructions; -162.7M instructions] or [-19.696%; -19.509%]

scenario:appsec-control-with-attacks-18

  • 🟩 cpu_user_time [-68.110ms; -61.357ms] or [-20.431%; -18.406%]
  • 🟩 execution_time [-68.698ms; -48.042ms] or [-16.567%; -11.586%]
  • 🟩 instructions [-147.2M instructions; -144.7M instructions] or [-17.743%; -17.447%]

scenario:appsec-iast-no-vulnerability-control-16

  • 🟩 cpu_user_time [-126.801ms; -103.556ms] or [-24.483%; -19.995%]
  • 🟩 execution_time [-175.526ms; -129.645ms] or [-24.263%; -17.921%]
  • 🟩 instructions [-273.7M instructions; -263.7M instructions] or [-21.890%; -21.085%]
  • 🟩 max_rss_usage [-4.979MB; -4.629MB] or [-7.813%; -7.265%]

scenario:appsec-iast-no-vulnerability-control-18

  • 🟩 cpu_user_time [-134.989ms; -114.558ms] or [-26.009%; -22.072%]
  • 🟩 execution_time [-158.180ms; -105.022ms] or [-23.124%; -15.353%]
  • 🟩 instructions [-247.9M instructions; -238.7M instructions] or [-19.925%; -19.185%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-16

  • 🟩 cpu_usage_percentage [-18.644%; -15.844%]
  • 🟩 cpu_user_time [-3.060s; -3.031s] or [-88.680%; -87.853%]
  • 🟩 execution_time [-3.081s; -3.033s] or [-85.040%; -83.722%]
  • 🟩 instructions [-1.0G instructions; -1.0G instructions] or [-50.873%; -50.385%]
  • 🟩 max_rss_usage [-57.068MB; -53.860MB] or [-49.857%; -47.055%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟩 cpu_usage_percentage [-11.940%; -8.159%]
  • 🟩 cpu_user_time [-691.487ms; -664.948ms] or [-65.171%; -62.670%]
  • 🟩 execution_time [-722.412ms; -678.003ms] or [-58.300%; -54.716%]
  • 🟩 instructions [-876.6M instructions; -867.9M instructions] or [-46.918%; -46.450%]
  • 🟩 max_rss_usage [-41.313MB; -39.715MB] or [-36.910%; -35.482%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-16

  • 🟩 cpu_usage_percentage [-18.832%; -14.663%]
  • 🟩 cpu_user_time [-3.021s; -2.986s] or [-88.675%; -87.645%]
  • 🟩 execution_time [-3.039s; -2.985s] or [-84.985%; -83.477%]
  • 🟩 instructions [-853.1M instructions; -843.1M instructions] or [-46.616%; -46.068%]
  • 🟩 max_rss_usage [-57.633MB; -55.216MB] or [-49.939%; -47.844%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟩 cpu_usage_percentage [-14.455%; -9.885%]
  • 🟩 cpu_user_time [-636.325ms; -611.436ms] or [-62.378%; -59.938%]
  • 🟩 execution_time [-657.784ms; -610.443ms] or [-55.203%; -51.230%]
  • 🟩 instructions [-699.5M instructions; -685.7M instructions] or [-41.314%; -40.497%]
  • 🟩 max_rss_usage [-40.615MB; -38.237MB] or [-36.668%; -34.521%]

scenario:appsec-iast-startup-time-control-16

  • 🟩 cpu_user_time [-93.149ms; -73.228ms] or [-12.592%; -9.899%]
  • 🟩 execution_time [-91.256ms; -64.269ms] or [-10.813%; -7.615%]
  • 🟩 instructions [-92.5M instructions; -90.8M instructions] or [-5.171%; -5.076%]

scenario:appsec-iast-startup-time-control-18

  • 🟩 cpu_user_time [-96.663ms; -73.031ms] or [-12.804%; -9.674%]
  • 🟩 execution_time [-93.861ms; -69.677ms] or [-10.868%; -8.067%]

scenario:appsec-iast-startup-time-iast-enabled-16

  • 🟩 cpu_user_time [-3.004s; -2.977s] or [-82.416%; -81.668%]
  • 🟩 execution_time [-3.026s; -2.998s] or [-80.136%; -79.383%]
  • 🟩 instructions [-843.7M instructions; -830.4M instructions] or [-33.301%; -32.776%]
  • 🟩 max_rss_usage [-44.141MB; -41.982MB] or [-35.060%; -33.346%]

scenario:appsec-iast-startup-time-iast-enabled-18

  • 🟩 cpu_user_time [-689.267ms; -663.732ms] or [-51.106%; -49.212%]
  • 🟩 execution_time [-731.016ms; -709.429ms] or [-48.957%; -47.511%]
  • 🟩 instructions [-533.6M instructions; -529.0M instructions] or [-23.889%; -23.681%]
  • 🟩 max_rss_usage [-28.273MB; -26.426MB] or [-23.411%; -21.882%]

scenario:appsec-iast-with-vulnerability-control-16

  • 🟩 cpu_user_time [-175.726ms; -142.361ms] or [-21.372%; -17.314%]
  • 🟩 execution_time [-306.166ms; -234.911ms] or [-24.932%; -19.130%]
  • 🟩 instructions [-342.9M instructions; -332.1M instructions] or [-17.141%; -16.603%]
  • 🟩 max_rss_usage [-7.199MB; -6.604MB] or [-10.087%; -9.252%]

scenario:appsec-iast-with-vulnerability-control-18

  • 🟩 cpu_user_time [-180.212ms; -146.262ms] or [-21.540%; -17.482%]
  • 🟩 execution_time [-235.168ms; -151.440ms] or [-19.465%; -12.535%]
  • 🟩 instructions [-295.4M instructions; -286.3M instructions] or [-14.769%; -14.317%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-16

  • 🟩 cpu_user_time [-3.518s; -3.441s] or [-84.927%; -83.076%]
  • 🟩 execution_time [-3.871s; -3.720s] or [-80.982%; -77.838%]
  • 🟩 instructions [-1.7G instructions; -1.7G instructions] or [-50.783%; -50.168%]
  • 🟩 max_rss_usage [-53.018MB; -49.931MB] or [-45.611%; -42.956%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

  • 🟩 cpu_user_time [-896.531ms; -856.245ms] or [-57.627%; -55.038%]
  • 🟩 execution_time [-1.276s; -1.164s] or [-57.018%; -52.027%]
  • 🟩 instructions [-1.5G instructions; -1.5G instructions] or [-46.770%; -46.188%]
  • 🟩 max_rss_usage [-40.585MB; -38.685MB] or [-33.805%; -32.222%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-16

  • 🟩 cpu_user_time [-3.383s; -3.311s] or [-84.558%; -82.755%]
  • 🟩 execution_time [-3.701s; -3.551s] or [-80.567%; -77.305%]
  • 🟩 instructions [-1.3G instructions; -1.2G instructions] or [-43.171%; -42.099%]
  • 🟩 max_rss_usage [-52.229MB; -48.137MB] or [-45.543%; -41.975%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

  • 🟩 cpu_user_time [-746.782ms; -708.773ms] or [-53.396%; -50.679%]
  • 🟩 execution_time [-1033.153ms; -930.532ms] or [-52.194%; -47.009%]
  • 🟩 instructions [-1.1G instructions; -1.0G instructions] or [-38.619%; -37.048%]
  • 🟩 max_rss_usage [-37.361MB; -34.840MB] or [-32.094%; -29.929%]

scenario:appsec-startup-time-appsec-enabled-16

  • 🟩 cpu_user_time [-123.717ms; -112.833ms] or [-16.413%; -14.969%]
  • 🟩 execution_time [-125.724ms; -112.228ms] or [-14.848%; -13.254%]
  • 🟩 instructions [-242.8M instructions; -241.9M instructions] or [-12.523%; -12.477%]

scenario:appsec-startup-time-appsec-enabled-18

  • 🟩 cpu_user_time [-75.573ms; -64.703ms] or [-10.483%; -8.975%]
  • 🟩 execution_time [-78.402ms; -66.875ms] or [-9.601%; -8.189%]
  • 🟩 instructions [-224.8M instructions; -223.9M instructions] or [-11.670%; -11.621%]
  • 🟩 max_rss_usage [-5.225MB; -4.960MB] or [-5.304%; -5.034%]

scenario:appsec-startup-time-control-16

  • 🟩 cpu_user_time [-86.680ms; -75.966ms] or [-12.045%; -10.556%]
  • 🟩 execution_time [-88.551ms; -76.100ms] or [-10.942%; -9.403%]
  • 🟩 instructions [-93.5M instructions; -91.1M instructions] or [-5.227%; -5.095%]

scenario:appsec-startup-time-control-18

  • 🟩 cpu_user_time [-79.844ms; -68.654ms] or [-11.016%; -9.472%]
  • 🟩 execution_time [-83.616ms; -69.785ms] or [-10.189%; -8.503%]

scenario:log-skip-log-18

  • 🟩 cpu_user_time [-31.521ms; -23.493ms] or [-9.443%; -7.038%]
  • 🟩 execution_time [-27.990ms; -26.990ms] or [-7.614%; -7.342%]

scenario:log-with-debug-18

  • 🟩 cpu_user_time [-28.527ms; -20.449ms] or [-8.589%; -6.157%]
  • 🟩 execution_time [-27.980ms; -27.017ms] or [-7.613%; -7.351%]

scenario:log-with-error-18

  • 🟩 cpu_user_time [-28.114ms; -19.617ms] or [-8.498%; -5.930%]
  • 🟩 execution_time [-28.106ms; -27.123ms] or [-7.644%; -7.377%]

scenario:log-without-log-18

  • 🟩 cpu_user_time [-31.752ms; -22.869ms] or [-10.007%; -7.207%]
  • 🟩 execution_time [-29.779ms; -28.366ms] or [-8.478%; -8.076%]

scenario:net-with-tracer-16

  • 🟩 cpu_usage_percentage [-5.651%; -5.570%]
  • 🟩 cpu_user_time [-109.492ms; -102.652ms] or [-33.030%; -30.967%]
  • 🟩 execution_time [-116.002ms; -115.149ms] or [-24.263%; -24.085%]
  • 🟩 instructions [-191.1M instructions; -190.7M instructions] or [-23.986%; -23.943%]
  • 🟩 max_rss_usage [-3.418MB; -3.389MB] or [-6.323%; -6.268%]

scenario:net-with-tracer-18

  • 🟩 cpu_usage_percentage [-5.064%; -5.000%]
  • 🟩 cpu_user_time [-105.933ms; -98.439ms] or [-31.668%; -29.427%]
  • 🟩 execution_time [-110.219ms; -109.406ms] or [-23.024%; -22.854%]
  • 🟩 instructions [-182.2M instructions; -181.8M instructions] or [-22.633%; -22.590%]

scenario:plugin-dns-with-tracer-16

  • 🟩 cpu_usage_percentage [-12.622%; -12.217%]
  • 🟩 cpu_user_time [-248.314ms; -231.912ms] or [-52.708%; -49.226%]
  • 🟩 execution_time [-285.601ms; -236.919ms] or [-16.655%; -13.816%]
  • 🟩 instructions [-436.4M instructions; -428.9M instructions] or [-43.455%; -42.711%]
  • 🟩 max_rss_usage [-7.232MB; -7.000MB] or [-12.622%; -12.217%]

scenario:plugin-dns-with-tracer-18

  • 🟩 cpu_usage_percentage [-11.955%; -11.497%]
  • 🟩 cpu_user_time [-244.127ms; -228.742ms] or [-51.195%; -47.969%]
  • 🟩 execution_time [-281.092ms; -224.001ms] or [-16.204%; -12.913%]
  • 🟩 instructions [-407.3M instructions; -401.5M instructions] or [-40.614%; -40.039%]
  • 🟩 max_rss_usage [-5.663MB; -5.433MB] or [-8.281%; -7.946%]

scenario:plugin-graphql-with-depth-and-collapse-off-16

  • 🟩 cpu_user_time [-12.403s; -11.864s] or [-81.972%; -78.405%]
  • 🟩 execution_time [-13.117s; -12.559s] or [-81.287%; -77.831%]
  • 🟩 instructions [-30.7G instructions; -30.6G instructions] or [-86.505%; -86.085%]
  • 🟩 max_rss_usage [-941.175MB; -934.617MB] or [-68.966%; -68.485%]

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟩 cpu_user_time [-13.742s; -12.495s] or [-85.015%; -77.302%]
  • 🟩 execution_time [-14.361s; -13.419s] or [-83.336%; -77.871%]
  • 🟩 instructions [-36.1G instructions; -35.6G instructions] or [-88.940%; -87.741%]
  • 🟩 max_rss_usage [-930.723MB; -857.037MB] or [-68.622%; -63.189%]

scenario:plugin-graphql-with-depth-and-collapse-on-16

  • 🟩 cpu_user_time [-7.521s; -7.267s] or [-72.362%; -69.917%]
  • 🟩 execution_time [-7.796s; -7.600s] or [-70.667%; -68.882%]
  • 🟩 instructions [-17.1G instructions; -17.0G instructions] or [-77.905%; -77.700%]
  • 🟩 max_rss_usage [-409.122MB; -402.426MB] or [-48.603%; -47.808%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 cpu_user_time [-8.059s; -7.995s] or [-73.102%; -72.524%]
  • 🟩 execution_time [-8.469s; -8.341s] or [-72.267%; -71.175%]
  • 🟩 instructions [-19.2G instructions; -19.1G instructions] or [-80.546%; -79.931%]
  • 🟩 max_rss_usage [-510.026MB; -485.482MB] or [-53.709%; -51.125%]

scenario:plugin-graphql-with-depth-off-16

  • 🟩 cpu_user_time [-7.938s; -7.625s] or [-73.386%; -70.498%]
  • 🟩 execution_time [-8.214s; -7.995s] or [-71.911%; -69.994%]
  • 🟩 instructions [-18.1G instructions; -18.0G instructions] or [-78.972%; -78.614%]
  • 🟩 max_rss_usage [-433.339MB; -431.985MB] or [-50.314%; -50.157%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 cpu_user_time [-8.510s; -8.305s] or [-74.620%; -72.820%]
  • 🟩 execution_time [-8.863s; -8.740s] or [-73.064%; -72.056%]
  • 🟩 instructions [-20.3G instructions; -20.1G instructions] or [-81.395%; -80.629%]
  • 🟩 max_rss_usage [-510.912MB; -494.708MB] or [-53.111%; -51.427%]

scenario:plugin-graphql-with-depth-on-max-16

  • 🟩 cpu_user_time [-7.574s; -7.281s] or [-72.502%; -69.702%]
  • 🟩 execution_time [-7.838s; -7.608s] or [-70.846%; -68.762%]
  • 🟩 instructions [-17.1G instructions; -17.0G instructions] or [-78.029%; -77.593%]
  • 🟩 max_rss_usage [-420.502MB; -397.182MB] or [-50.071%; -47.294%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 cpu_user_time [-8.067s; -7.972s] or [-73.249%; -72.391%]
  • 🟩 execution_time [-8.499s; -8.413s] or [-72.082%; -71.353%]
  • 🟩 instructions [-19.3G instructions; -19.2G instructions] or [-80.522%; -80.120%]
  • 🟩 max_rss_usage [-490.350MB; -485.326MB] or [-51.910%; -51.378%]

scenario:plugin-http-client-with-tracer-16

  • 🟩 cpu_usage_percentage [-8.425%; -8.345%]
  • 🟩 cpu_user_time [-357.867ms; -339.946ms] or [-46.859%; -44.512%]
  • 🟩 execution_time [-383.514ms; -373.612ms] or [-34.622%; -33.728%]
  • 🟩 instructions [-547.5M instructions; -546.9M instructions] or [-36.901%; -36.863%]
  • 🟩 max_rss_usage [-9.815MB; -9.665MB] or [-14.720%; -14.496%]

scenario:plugin-http-client-with-tracer-18

  • 🟩 cpu_usage_percentage [-7.677%; -7.570%]
  • 🟩 cpu_user_time [-320.518ms; -303.955ms] or [-43.933%; -41.663%]
  • 🟩 execution_time [-349.875ms; -339.710ms] or [-32.830%; -31.877%]
  • 🟩 instructions [-484.6M instructions; -483.5M instructions] or [-34.348%; -34.273%]
  • 🟩 max_rss_usage [-10.668MB; -10.348MB] or [-13.696%; -13.285%]

scenario:plugin-http-server-querystring-obfuscation-16

  • 🟥 cpu_usage_percentage [+11.600%; +11.803%]
  • 🟩 execution_time [-222.422ms; -213.155ms] or [-22.248%; -21.321%]

scenario:plugin-http-server-querystring-obfuscation-18

  • 🟥 cpu_usage_percentage [+10.407%; +10.577%]
  • 🟩 execution_time [-213.547ms; -203.735ms] or [-22.180%; -21.161%]

scenario:plugin-http-server-with-tracer-16

  • 🟥 cpu_usage_percentage [+10.480%; +10.666%]
  • 🟩 execution_time [-196.588ms; -187.996ms] or [-20.950%; -20.034%]

scenario:plugin-http-server-with-tracer-18

  • 🟥 cpu_usage_percentage [+9.065%; +9.219%]
  • 🟩 execution_time [-182.536ms; -173.812ms] or [-20.149%; -19.186%]

scenario:plugin-q-with-tracer-16

  • 🟩 cpu_user_time [-115.986ms; -98.468ms] or [-13.846%; -11.755%]
  • 🟩 execution_time [-115.684ms; -101.346ms] or [-12.560%; -11.004%]
  • 🟩 instructions [-118.9M instructions; -108.1M instructions] or [-7.074%; -6.432%]

scenario:plugin-q-with-tracer-18

  • 🟩 cpu_user_time [-144.090ms; -127.079ms] or [-16.341%; -14.412%]
  • 🟩 execution_time [-145.121ms; -129.657ms] or [-14.984%; -13.387%]

@ida613
ida613 marked this pull request as draft August 31, 2023 19:55
ida613
ida613 previously approved these changes Sep 12, 2023
View reviewed changes
@ida613 ida613 changed the title Adding required headers for Instrumentation Telemetry upgrade instrumentation telemetry from v1 to v2 Sep 13, 2023
@juan-fernandez juan-fernandez mentioned this pull request Nov 1, 2023
Merged
@ida613 ida613 mentioned this pull request Nov 27, 2023
Merged
8 tasks
@ida613 ida613 closed this Jan 12, 2024
@tlhunter
tlhunter deleted the inTelHeaders branch January 19, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Qard Qard Qard left review comments
@ida613 ida613 ida613 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crysmags @Qard @ida613 @sabrenner @bojbrook @tlhunter