Skip to content

pg: retain prototype when injecting DBM comment#3307

Merged
tlhunter merged 1 commit into
masterfrom
tlhunter/pg-query-proto
Jun 29, 2023
Merged

pg: retain prototype when injecting DBM comment#3307
tlhunter merged 1 commit into
masterfrom
tlhunter/pg-query-proto

Conversation

@tlhunter

@tlhunter tlhunter commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • at first we overwrite query.text, but when it was a getter it would crash
  • then we made a shallow clone of query, but it lost important prototype methods
  • now we're making a new object and using query as the prototype

Motivation

@tlhunter
tlhunter requested a review from rochdev June 28, 2023 23:44
@tlhunter
tlhunter requested a review from a team as a code owner June 28, 2023 23:44
@tlhunter tlhunter mentioned this pull request Jun 28, 2023
Closed
@github-actions

github-actions Bot commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.73 MB
Deduped: 61.19 MB
No deduping: 61.23 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.3 14.25 MB 15.13 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@tlhunter
tlhunter force-pushed the tlhunter/pg-query-proto branch from 905dab9 to b059bea Compare June 28, 2023 23:59
@codecov

codecov Bot commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3307 (256528a) into master (d6ce94f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3307   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files         200      200           
  Lines        7766     7766           
  Branches       33       33           
=======================================
  Hits         6677     6677           
  Misses       1089     1089

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlhunter
tlhunter force-pushed the tlhunter/pg-query-proto branch from b059bea to 855641f Compare June 29, 2023 00:06
@pr-commenter

pr-commenter Bot commented Jun 29, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Comparing candidate commit 256528a in PR branch tlhunter/pg-query-proto with baseline commit d6ce94f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 464 metrics, 28 unstable metrics.

@tlhunter
tlhunter force-pushed the tlhunter/pg-query-proto branch from 855641f to 256528a Compare June 29, 2023 16:01
@tlhunter
tlhunter merged commit dcaaa5c into master Jun 29, 2023
@tlhunter
tlhunter deleted the tlhunter/pg-query-proto branch June 29, 2023 16:14
This was referenced Jun 29, 2023
Merged
Merged
Merged
tlhunter added a commit that referenced this pull request Jun 30, 2023
@tlhunter
pg: retain prototype when injecting DBM comment (#3307)
acb9499
tlhunter added a commit that referenced this pull request Jun 30, 2023
@tlhunter
pg: retain prototype when injecting DBM comment (#3307)
8955181
tlhunter added a commit that referenced this pull request Jun 30, 2023
@tlhunter
pg: retain prototype when injecting DBM comment (#3307)
9c036c9
tlhunter added a commit that referenced this pull request Jun 30, 2023
@tlhunter
pg: retain prototype when injecting DBM comment (#3307)
a15cf9c
tlhunter added a commit that referenced this pull request Jun 30, 2023
@tlhunter
pg: retain prototype when injecting DBM comment (#3307)
4a1e4a6
tlhunter added a commit that referenced this pull request Jun 30, 2023
@tlhunter
pg: retain prototype when injecting DBM comment (#3307)
854c252
@rochdev rochdev mentioned this pull request Aug 31, 2023
Merged
@erikvanbrakel erikvanbrakel mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rochdev rochdev rochdev approved these changes

Assignees

No one assigned

Labels

integration-pg semver-patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pg is not being instrumented properly

2 participants

@tlhunter @rochdev