pg: do not throw when query contains getter#3212
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.24 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3212 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 182 182
Lines 7229 7229
Branches 33 33
=======================================
Hits 6200 6200
Misses 1029 1029 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tlhunter
force-pushed
the
tlhunter/dbm-pg-query-getter
branch
2 times, most recently
from
June 2, 2023 20:28
649e31a to
0248a1c
Compare
tlhunter
force-pushed
the
tlhunter/dbm-pg-query-getter
branch
from
June 2, 2023 20:32
0248a1c to
32d1e9b
Compare
tlhunter
marked this pull request as ready for review
June 2, 2023 20:39
Qard
approved these changes
Jun 2, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 7, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 7, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 7, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 8, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 8, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 8, 2023
|
FYI @tlhunter @Qard, this PR seems to have introduced bug #3239 which has broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sql-template-stringslibrary seems to generate a complex query object with the use of getters/setters:dd-trace-js/packages/datadog-plugin-pg/src/index.js
Line 30 in dec9dd3
The failure then happens since one cannot write to a getter unless a setter is present.
Motivation