postgres: DBM full service fallback w/ prepared statements#3186
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.18 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
tlhunter
force-pushed
the
tlhunter/dbm-pg-prepared-statements
branch
from
May 24, 2023 17:29
3dd5e98 to
0864b0f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3186 +/- ##
==========================================
- Coverage 86.57% 86.54% -0.03%
==========================================
Files 333 331 -2
Lines 11934 11894 -40
Branches 33 33
==========================================
- Hits 10332 10294 -38
+ Misses 1602 1600 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tlhunter
force-pushed
the
tlhunter/dbm-pg-prepared-statements
branch
from
May 31, 2023 19:44
0864b0f to
5f2d2b1
Compare
tlhunter
commented
May 31, 2023
| let queryText = '' | ||
|
|
||
| const query = { | ||
| name: 'pgSelectQuery', |
Member
Author
There was a problem hiding this comment.
This was actually an example of the bug happening. The previous test had a name and was therefore a prepared statement. The test asserts that the traceparent is present in the comment but it should actually not be present.
tlhunter
marked this pull request as ready for review
May 31, 2023 19:52
Qard
approved these changes
May 31, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
- when DBM is set to full service - the DBM comment falls back to service mode - but only when sending a prepared statement - without this, each prepared statement query is technically different - this causes the pg library to fail as it does an exact string check of the query - ideally the pg library would somehow parse out and not consider comments - at any rate this brings parity with other tracer implementations - see brianc/node-postgres#2735 - previously attempted in 0ff9465
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
- when DBM is set to full service - the DBM comment falls back to service mode - but only when sending a prepared statement - without this, each prepared statement query is technically different - this causes the pg library to fail as it does an exact string check of the query - ideally the pg library would somehow parse out and not consider comments - at any rate this brings parity with other tracer implementations - see brianc/node-postgres#2735 - previously attempted in 0ff9465
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
- when DBM is set to full service - the DBM comment falls back to service mode - but only when sending a prepared statement - without this, each prepared statement query is technically different - this causes the pg library to fail as it does an exact string check of the query - ideally the pg library would somehow parse out and not consider comments - at any rate this brings parity with other tracer implementations - see brianc/node-postgres#2735 - previously attempted in 0ff9465
This was referenced Jun 1, 2023
Merged
Merged
Merged
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
- when DBM is set to full service - the DBM comment falls back to service mode - but only when sending a prepared statement - without this, each prepared statement query is technically different - this causes the pg library to fail as it does an exact string check of the query - ideally the pg library would somehow parse out and not consider comments - at any rate this brings parity with other tracer implementations - see brianc/node-postgres#2735 - previously attempted in 0ff9465
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
- when DBM is set to full service - the DBM comment falls back to service mode - but only when sending a prepared statement - without this, each prepared statement query is technically different - this causes the pg library to fail as it does an exact string check of the query - ideally the pg library would somehow parse out and not consider comments - at any rate this brings parity with other tracer implementations - see brianc/node-postgres#2735 - previously attempted in 0ff9465
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
- when DBM is set to full service - the DBM comment falls back to service mode - but only when sending a prepared statement - without this, each prepared statement query is technically different - this causes the pg library to fail as it does an exact string check of the query - ideally the pg library would somehow parse out and not consider comments - at any rate this brings parity with other tracer implementations - see brianc/node-postgres#2735 - previously attempted in 0ff9465
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Plugin Checklist