Make HTTP clients fit in the plugin hierarchy#3178
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.18 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
jbertran
force-pushed
the
jbertran/http-client-tree
branch
from
May 22, 2023 16:08
b58b131 to
41fce29
Compare
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 86.57% 86.56% -0.01%
==========================================
Files 333 333
Lines 11934 11928 -6
Branches 33 33
==========================================
- Hits 10332 10326 -6
Misses 1602 1602
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jbertran
marked this pull request as ready for review
May 22, 2023 16:13
jbertran
force-pushed
the
jbertran/http-client-tree
branch
5 times, most recently
from
May 24, 2023 13:33
1d03fe3 to
8ab1379
Compare
jbertran
force-pushed
the
jbertran/http-client-tree
branch
from
May 30, 2023 09:04
8ab1379 to
cfae42e
Compare
tlhunter
previously approved these changes
May 30, 2023
tlhunter
left a comment
tlhunter
left a comment
Member
There was a problem hiding this comment.
This looks good to me. It makes sense that an HTTP client would extend from ClientPlugin, being a client and all.
This appears to be entirely a refactor, nothing new, and the untouched tests all pass.
That said I would like @rochdev to take a quick look.
rochdev
reviewed
May 30, 2023
Member
There was a problem hiding this comment.
Why not keep it there? If there are no publishers, this doesn't impact anything.
Contributor
Author
There was a problem hiding this comment.
I wasn't sure of the impact of subscribing to a channel, so I removed it by default. I'll revert this so we have an easy way to grab connect events in every client.
jbertran
force-pushed
the
jbertran/http-client-tree
branch
from
May 31, 2023 08:51
cfae42e to
cac2cd6
Compare
rochdev
approved these changes
May 31, 2023
rochdev
approved these changes
May 31, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
* move http client to clientPlugin * move http2 client to clientPlugin
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
* move http client to clientPlugin * move http2 client to clientPlugin
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
* move http client to clientPlugin * move http2 client to clientPlugin
This was referenced Jun 1, 2023
Merged
Merged
Merged
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
* move http client to clientPlugin * move http2 client to clientPlugin
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
* move http client to clientPlugin * move http2 client to clientPlugin
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
* move http client to clientPlugin * move http2 client to clientPlugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ClientPluginconnectchannels in allOutboundPlugins, since only cassandra actually uses this channelMotivation
To introduce peer service (see #3177), it's helpful for all client/producer plugins to have at least OutboundPlugin in their inheritance path.
Plugin Checklist
Additional Notes