[ci-visibility] Test skipping logic for cypress#3167
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.19 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3167 +/- ##
==========================================
+ Coverage 86.54% 87.71% +1.16%
==========================================
Files 333 247 -86
Lines 11895 9141 -2754
Branches 33 33
==========================================
- Hits 10295 8018 -2277
+ Misses 1600 1123 -477
... and 95 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juan-fernandez
force-pushed
the
juan-fernandez/add-itr-to-cypress
branch
from
May 23, 2023 09:02
8e234ac to
34ecedc
Compare
juan-fernandez
changed the title
juan-fernandez
force-pushed
the
juan-fernandez/add-itr-to-cypress
branch
from
May 23, 2023 12:34
a448176 to
bf428e3
Compare
rochdev
requested changes
May 30, 2023
| "test:integration:cucumber": "mocha --colors --timeout 30000 \"integration-tests/cucumber/*.spec.js\"", | ||
| "test:integration:cypress": "mocha --colors --timeout 30000 \"integration-tests/cypress/*.spec.js\"", | ||
| "test:integration:playwright": "mocha --colors --timeout 30000 \"integration-tests/playwright/*.spec.js\"", | ||
| "test:integration:cucumber": "mocha --colors --timeout 30000 --exit \"integration-tests/cucumber/*.spec.js\"", |
Member
There was a problem hiding this comment.
Why is this needed? Needing this means the test isn't exiting properly and Mocha needs to kill it. Not only is this working around the issue, it won't be compatible with tap.
Collaborator
Author
There was a problem hiding this comment.
yeah there was some kind of weird race condition where if the test ended before the cypress process was finished, a handle was kept alive, not allowing the process to finish. I can't explain it but this change seems to fix it
rochdev
approved these changes
May 31, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
Merged
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ITR logic to cypress.
Motivation
Allow cypress users to use ITR.