[ci-visibility] Extract code coverage from cypress#3159
Merged
juan-fernandez merged 8 commits intoMay 23, 2023
Conversation
Contributor
Overall package sizeSelf size: 4.16 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3159 +/- ##
==========================================
- Coverage 86.95% 86.64% -0.31%
==========================================
Files 322 328 +6
Lines 11763 11866 +103
Branches 33 33
==========================================
+ Hits 10228 10281 +53
- Misses 1535 1585 +50
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juan-fernandez
force-pushed
the
juan-fernandez/extra-coverage-from-cypress
branch
from
May 17, 2023 10:51
155908b to
566fa65
Compare
juan-fernandez
marked this pull request as ready for review
May 17, 2023 11:01
Collaborator
Author
|
I'm moving this back to draft because I found an important bug |
juan-fernandez
marked this pull request as draft
May 18, 2023 10:16
juan-fernandez
force-pushed
the
juan-fernandez/extra-coverage-from-cypress
branch
from
May 18, 2023 10:49
567cc36 to
eaac6b5
Compare
juan-fernandez
commented
May 18, 2023
| traceId: this.testSuiteSpan.context()._traceId, | ||
| spanId: this.testSuiteSpan.context()._spanId, | ||
| sessionId: this.testSuiteSpan.context()._traceId, | ||
| suiteId: this.testSuiteSpan.context()._spanId, |
Collaborator
Author
There was a problem hiding this comment.
unrelated fix: these names make more sense, given that that's what we end up encoding
Collaborator
Author
ok that should be fixed |
juan-fernandez
marked this pull request as ready for review
May 18, 2023 11:51
simon-id
reviewed
May 22, 2023
| const coverageFiles = getCoveredFilenamesFromCoverage(coverage) | ||
| const relativeCoverageFiles = coverageFiles.map(file => getTestSuitePath(file, rootDir)) | ||
| const formattedCoverage = { | ||
| sessionId: testSuiteSpan.context()._traceId, |
Contributor
There was a problem hiding this comment.
no need to call .context() twice no ?
Contributor
There was a problem hiding this comment.
everytime i use both spanId and traceId i usually "cache" the span context
Collaborator
Author
There was a problem hiding this comment.
true. Will change that
simon-id
reviewed
May 22, 2023
simon-id
approved these changes
May 22, 2023
simon-id
previously approved these changes
May 22, 2023
uurien
previously approved these changes
May 22, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
uurien
approved these changes
May 23, 2023
thedavl
pushed a commit
that referenced
this pull request
May 30, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
uurien
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
This was referenced Jun 1, 2023
Merged
Merged
Merged
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
uurien
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If
window.__coverage__available from the test's context, it means that the web app has been instrumented with code coverage. If that's the case, we extract it.Motivation
First step to making ITR usable with cypress.