Skip to content

[ci-visibility] Fix cucumber parallel mode#3156

Merged
juan-fernandez merged 2 commits into
masterfrom
juan-fernandez/fix-cucumber-parallel
May 23, 2023
Merged

[ci-visibility] Fix cucumber parallel mode#3156
juan-fernandez merged 2 commits into
masterfrom
juan-fernandez/fix-cucumber-parallel

Conversation

@juan-fernandez

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fix error when running cucumber in parallel mode.

Motivation

Fixes #3151

@juan-fernandez
juan-fernandez marked this pull request as ready for review May 16, 2023 08:43
@juan-fernandez
juan-fernandez requested a review from a team as a code owner May 16, 2023 08:43
@github-actions

github-actions Bot commented May 16, 2023

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.15 MB
Deduped: 58.28 MB
No deduping: 58.33 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented May 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3156 (1273e90) into master (cad3d92) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3156      +/-   ##
==========================================
- Coverage   86.98%   86.65%   -0.34%     
==========================================
  Files         322      328       +6     
  Lines       11763    11853      +90     
  Branches       33       33              
==========================================
+ Hits        10232    10271      +39     
- Misses       1531     1582      +51     
Impacted Files Coverage Δ
packages/datadog-instrumentations/src/cucumber.js 0.00% <0.00%> (ø)

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter

pr-commenter Bot commented May 16, 2023

Copy link
Copy Markdown

Benchmarks

Comparing candidate commit 1273e90 in PR branch juan-fernandez/fix-cucumber-parallel with baseline commit cad3d92 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 441 metrics, 31 unstable metrics.

Comment thread integration-tests/cucumber/cucumber.spec.js
@juan-fernandez
juan-fernandez requested a review from uurien May 22, 2023 14:09
@juan-fernandez
juan-fernandez merged commit bc2b4a6 into master May 23, 2023
@juan-fernandez
juan-fernandez deleted the juan-fernandez/fix-cucumber-parallel branch May 23, 2023 07:16
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
This was referenced Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cucumber-js parallel support

2 participants