Skip to content

Use 'process' as default strategy for oom export#3136

Merged
nsavoire merged 1 commit into
masterfrom
nsavoire/use_process_strategy_as_default
May 17, 2023
Merged

Use 'process' as default strategy for oom export#3136
nsavoire merged 1 commit into
masterfrom
nsavoire/use_process_strategy_as_default

Conversation

@nsavoire

Copy link
Copy Markdown
Collaborator

What does this PR do?

Use process as default strategy for oom export.

Motivation

process is the safer export strategy for heap profile export upon oom.

'process' is the safer export strategy for heap profile export upon oom.
@nsavoire
nsavoire requested review from r1viollet and szegedi May 11, 2023 12:03
@nsavoire
nsavoire requested a review from a team as a code owner May 11, 2023 12:03
@github-actions

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.11 MB
Deduped: 58.24 MB
No deduping: 58.28 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented May 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3136 (46b7986) into master (4e7da80) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3136      +/-   ##
==========================================
+ Coverage   87.15%   87.29%   +0.14%     
==========================================
  Files         316      312       -4     
  Lines       11585    11462     -123     
  Branches       33       33              
==========================================
- Hits        10097    10006      -91     
+ Misses       1488     1456      -32     
Impacted Files Coverage Δ
packages/dd-trace/src/profiling/config.js 95.91% <100.00%> (-1.03%) ⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter

pr-commenter Bot commented May 11, 2023

Copy link
Copy Markdown

Benchmarks

Comparing candidate commit 46b7986 in PR branch nsavoire/use_process_strategy_as_default with baseline commit 4e7da80 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 663 metrics, 45 unstable metrics.

@nsavoire
nsavoire merged commit 0f3afc9 into master May 17, 2023
@nsavoire
nsavoire deleted the nsavoire/use_process_strategy_as_default branch May 17, 2023 21:35
thedavl pushed a commit that referenced this pull request May 30, 2023
'process' is the safer export strategy for heap profile export upon oom.
uurien pushed a commit that referenced this pull request Jun 1, 2023
'process' is the safer export strategy for heap profile export upon oom.
uurien pushed a commit that referenced this pull request Jun 1, 2023
'process' is the safer export strategy for heap profile export upon oom.
uurien pushed a commit that referenced this pull request Jun 1, 2023
'process' is the safer export strategy for heap profile export upon oom.
This was referenced Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
'process' is the safer export strategy for heap profile export upon oom.
uurien pushed a commit that referenced this pull request Jun 2, 2023
'process' is the safer export strategy for heap profile export upon oom.
uurien pushed a commit that referenced this pull request Jun 2, 2023
'process' is the safer export strategy for heap profile export upon oom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants