Skip to content

implement RC custom rules#3126

Merged
simon-id merged 6 commits into
masterfrom
appsec_rc_custom_rules
May 23, 2023
Merged

implement RC custom rules#3126
simon-id merged 6 commits into
masterfrom
appsec_rc_custom_rules

Conversation

@simon-id

@simon-id simon-id commented May 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Add support for custom_rules field in ASM RC product. Allowing users to create custom rules from the dashboard.

@github-actions

github-actions Bot commented May 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.17 MB
Deduped: 58.37 MB
No deduping: 58.41 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented May 10, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3126 (de354b1) into master (15b2767) will increase coverage by 0.02%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
+ Coverage   86.54%   86.57%   +0.02%     
==========================================
  Files         333      333              
  Lines       11895    11907      +12     
  Branches       33       33              
==========================================
+ Hits        10295    10308      +13     
+ Misses       1600     1599       -1
Impacted Files Coverage Δ
.../dd-trace/src/appsec/remote_config/capabilities.js 100.00% <ø> (ø)
packages/dd-trace/src/appsec/rule_manager.js 91.52% <81.81%> (-1.07%) ⬇️
...ackages/dd-trace/src/appsec/remote_config/index.js 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter

pr-commenter Bot commented May 10, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Comparing candidate commit de354b1 in PR branch appsec_rc_custom_rules with baseline commit 15b2767 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 449 metrics, 23 unstable metrics.

@simon-id simon-id self-assigned this May 23, 2023
@simon-id
simon-id marked this pull request as ready for review May 23, 2023 10:18
@simon-id
simon-id requested review from a team as code owners May 23, 2023 10:18
@simon-id
simon-id merged commit e9298bf into master May 23, 2023
thedavl pushed a commit that referenced this pull request May 30, 2023
@simon-id @thedavl
Implement RC custom rules (#3126)
8e8b50b 
* implement RC custom rules

* update waf bindings to 3.2.0
uurien pushed a commit that referenced this pull request Jun 1, 2023
@simon-id
Implement RC custom rules (#3126)
9b10bd2 
* implement RC custom rules

* update waf bindings to 3.2.0
uurien pushed a commit that referenced this pull request Jun 1, 2023
@simon-id
Implement RC custom rules (#3126)
af22048 
* implement RC custom rules

* update waf bindings to 3.2.0
uurien pushed a commit that referenced this pull request Jun 1, 2023
@simon-id
Implement RC custom rules (#3126)
fca2369 
* implement RC custom rules

* update waf bindings to 3.2.0
This was referenced Jun 2, 2023
Merged
Merged
Merged
uurien pushed a commit that referenced this pull request Jun 2, 2023
@simon-id @uurien
Implement RC custom rules (#3126)
98a8740 
* implement RC custom rules

* update waf bindings to 3.2.0
uurien pushed a commit that referenced this pull request Jun 2, 2023
@simon-id @uurien
Implement RC custom rules (#3126)
71b0fc9 
* implement RC custom rules

* update waf bindings to 3.2.0
uurien pushed a commit that referenced this pull request Jun 2, 2023
@simon-id @uurien
Implement RC custom rules (#3126)
3bdad2c 
* implement RC custom rules

* update waf bindings to 3.2.0
@simon-id
simon-id deleted the appsec_rc_custom_rules branch January 8, 2024 08:28
@erikvanbrakel erikvanbrakel mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@uurien uurien uurien approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@simon-id simon-id

Labels

asm-waf semver-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simon-id @uurien