fix possible app crash when used with meteor 2.0#1233
Merged
Conversation
bengl
requested changes
Feb 3, 2021
rochdev
added a commit
that referenced
this pull request
Feb 4, 2021
Contributor
|
Does anybody know if this was a performance regression, or if there are plans to restore |
Member
Author
|
@schmod The new scope manager basically does the same thing that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix possible app crash in latest when used with Meteor 2.0 by updating the tracer to default to the
async_resourcescope manager since the issue seems to be a bug inAsyncLocalStorage.Motivation
Applications using Meteor 2.0 with the tracer are experiencing random C++ errors. While it's still unclear why this is happening, switching to the
executionAsyncResourcebased scope manager seems to resolve the issue.Fixes #1229