Address review comments

watson · watson · commit f3feb11fc2f6 · 2026-05-19T14:20:21.000+02:00
diff --git a/eslint-rules/eslint-prefer-assert-match.mjs b/eslint-rules/eslint-prefer-assert-match.mjs
@@ -176,7 +176,10 @@ function buildReplacementParts (match, sourceCode) {
     case 'test': {
       const stringNode = arg
       const regexNode = callee.object
-      return { stringNode, regexText: sourceCode.getText(regexNode), autofixable: true }
+      if (isRegexLiteral(regexNode)) {
+        return { stringNode, regexText: sourceCode.getText(regexNode), autofixable: true }
+      }
+      return { stringNode, regexText: null, autofixable: false }
     }
 
     default:
diff --git a/eslint-rules/eslint-prefer-assert-match.test.mjs b/eslint-rules/eslint-prefer-assert-match.test.mjs
@@ -71,12 +71,20 @@ ruleTester.run('eslint-prefer-assert-match', /** @type {import('eslint').Rule.Ru
       output: "assert.doesNotMatch(x, /foo/, 'should not match')",
       errors: [{ messageId: 'preferDoesNotMatch' }],
     },
-    // RegExp identifier (non-literal) is still fixable: just shuffles args.
+    // Non-regex-literal receivers of `.test()` are reported but not auto-fixed:
+    // the receiver might not be a RegExp (e.g. a Joi schema, AJV instance, or
+    // any other helper with a `.test()` method), so blindly rewriting to
+    // `assert.match(x, re)` could throw `TypeError: regexp must be a RegExp`.
     {
       code: 'assert.ok(re.test(x))',
-      output: 'assert.match(x, re)',
+      output: null,
       errors: [{ messageId: 'preferMatch' }],
     },
+    {
+      code: 'assert.ok(predicate.test(value))',
+      output: null,
+      errors: [{ messageId: 'preferMatch', data: { method: 'test' } }],
+    },
 
     // ── String.prototype.match() ──────────────────────────────────────────
     {
