chore(eslint): add no-does-not-throw rule (#7692)

bm1549 · claude · BridgeAR · web-flow · commit 9f2cfb674116 · 2026-03-06T18:01:02.000Z
Add an ESLint rule that bans `assert.doesNotThrow()` in test files.
All entries where it was used are fixed and CLAUDE.md is adjusted,
since the comment is not needed anymore.

---------

Co-authored-by: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
Co-authored-by: Ruben Bridgewater &lt;ruben@bridgewater.de&gt;
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -210,6 +210,7 @@
 
 # Language Platform
 /* @DataDog/lang-platform-js
+/eslint-rules/ @DataDog/lang-platform-js
 
 /integration-tests/bun/ @DataDog/lang-platform-js
 /integration-tests/init.spec.js @DataDog/lang-platform-js
diff --git a/AGENTS.md b/AGENTS.md
@@ -115,8 +115,6 @@ Use `node:assert/strict` for standard assertions. For partial deep object checks
 
 Favor fewer `assert.deepStrictEqual`/`assertObjectContains` calls over many `assert.strictEqual` calls. Combine existing calls, when touching test files.
 
-Never use the `doesNotThrow()` assertion. Instead, execute the method directly.
-
 ### Time-Based Testing
 
 **Never rely on actual time passing in unit tests.** Use sinon's fake timers to mock time and make tests deterministic and fast.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -647,6 +647,10 @@ export default [
           'mocha',
         ],
       }],
+      'no-restricted-syntax': ['error', {
+        selector: "CallExpression:matches([callee.name='doesNotThrow'], [callee.property.name='doesNotThrow'])",
+        message: 'Do not use `assert.doesNotThrow()`. Execute the expression directly instead.',
+      }],
       'n/no-missing-require': 'off',
       'require-await': 'off',
     },
diff --git a/packages/datadog-instrumentations/test/express.spec.js b/packages/datadog-instrumentations/test/express.spec.js
@@ -79,7 +79,7 @@ withVersions('express', 'express', version => {
       // Router does not exist in Express 5
       it('should work correctly when router[method] is called without handler', () => {
         const router = express.Router()
-        assert.doesNotThrow(() => { router.bind('/test') })
+        router.bind('/test')
       })
     }
   })
diff --git a/packages/datadog-plugin-elasticsearch/test/index.spec.js b/packages/datadog-plugin-elasticsearch/test/index.spec.js
@@ -241,9 +241,7 @@ describe('Plugin', () => {
             })
 
             it('should support aborting the query', () => {
-              assert.doesNotThrow(() => {
-                client.ping(() => {}).abort()
-              })
+              client.ping(() => {}).abort()
             })
           })
         }
@@ -305,13 +303,10 @@ describe('Plugin', () => {
           })
 
           it('should support aborting the query', () => {
-            assert.doesNotThrow(() => {
-              const promise = client.ping()
-
-              if (promise.abort) {
-                promise.abort()
-              }
-            })
+            const promise = client.ping()
+            if (promise.abort) {
+              promise.abort()
+            }
           })
 
           it('should work with userland promises', done => {
diff --git a/packages/datadog-plugin-graphql/test/index.spec.js b/packages/datadog-plugin-graphql/test/index.spec.js
@@ -1155,10 +1155,8 @@ describe('Plugin', () => {
         it('should support multiple executions on a pre-parsed document', () => {
           const source = 'query MyQuery { hello(name: "world") }'
           const document = graphql.parse(source)
-          assert.doesNotThrow(() => {
-            graphql.execute({ schema, document })
-            graphql.execute({ schema, document })
-          })
+          graphql.execute({ schema, document })
+          graphql.execute({ schema, document })
         })
 
         it('should not fail without directives in the document ' +
@@ -1172,9 +1170,7 @@ describe('Plugin', () => {
           dc.channel('datadog:graphql:resolver:start').subscribe(noop)
 
           try {
-            assert.doesNotThrow(() => {
-              graphql.execute({ schema, document })
-            })
+            graphql.execute({ schema, document })
           } finally {
             dc.channel('datadog:graphql:resolver:start').unsubscribe(noop)
           }
@@ -1184,10 +1180,8 @@ describe('Plugin', () => {
           const source = 'query MyQuery { hello(name: "world") }'
           const document = graphql.parse(source)
 
-          assert.doesNotThrow(() => {
-            graphql.validate(schema, document)
-            graphql.validate(schema, document)
-          })
+          graphql.validate(schema, document)
+          graphql.validate(schema, document)
         })
 
         it('should support multi-operations documents', done => {
diff --git a/packages/datadog-plugin-http/test/server.spec.js b/packages/datadog-plugin-http/test/server.spec.js
@@ -193,7 +193,7 @@ describe('Plugin', () => {
           const req = new IncomingMessage()
           const res = new ServerResponse(req)
 
-          assert.doesNotThrow(() => res.emit('finish'))
+          res.emit('finish')
         })
 
         it('should not cause `end` to be called multiple times', done => {
diff --git a/packages/datadog-plugin-opensearch/test/index.spec.js b/packages/datadog-plugin-opensearch/test/index.spec.js
@@ -191,13 +191,10 @@ describe('Plugin', () => {
         })
 
         it('should support aborting the query', () => {
-          assert.doesNotThrow(() => {
-            const promise = client.ping()
-
-            if (promise.abort) {
-              promise.abort()
-            }
-          })
+          const promise = client.ping()
+          if (promise.abort) {
+            promise.abort()
+          }
         })
 
         it('should work with userland promises', done => {
diff --git a/packages/datadog-plugin-winston/test/index.spec.js b/packages/datadog-plugin-winston/test/index.spec.js
@@ -295,7 +295,7 @@ describe('Plugin', () => {
           }
 
           it('should skip injection without a store', async () => {
-            assert.doesNotThrow(() => winston.info('message'))
+            winston.info('message')
           })
         })
 
diff --git a/packages/datadog-plugin-ws/test/index.spec.js b/packages/datadog-plugin-ws/test/index.spec.js
@@ -150,9 +150,7 @@ describe('Plugin', () => {
             done()
           })
 
-          assert.doesNotThrow(() => {
-            client.off('message', neverAddedHandler)
-          })
+          client.off('message', neverAddedHandler)
         })
 
         it('should do automatic instrumentation for server connections', done => {
diff --git a/packages/dd-trace/test/appsec/iast/analyzers/hardcoded-password-analyzer.spec.js b/packages/dd-trace/test/appsec/iast/analyzers/hardcoded-password-analyzer.spec.js
@@ -1,7 +1,6 @@
 /* eslint-disable @stylistic/max-len */
 'use strict'
 
-const assert = require('node:assert/strict')
 const fs = require('node:fs')
 const os = require('node:os')
 const path = require('node:path')
@@ -66,11 +65,11 @@ describe('Hardcoded Password Analyzer', () => {
     })
 
     it('should not fail with a malformed secret', () => {
-      assert.doesNotThrow(() => hardcodedPasswordAnalyzer.analyze(undefined))
-      assert.doesNotThrow(() => hardcodedPasswordAnalyzer.analyze({ file: undefined }))
-      assert.doesNotThrow(() => hardcodedPasswordAnalyzer.analyze({ file, literals: undefined }))
-      assert.doesNotThrow(() => hardcodedPasswordAnalyzer.analyze({ file, literals: [{ value: undefined }] }))
-      assert.doesNotThrow(() => hardcodedPasswordAnalyzer.analyze({ file, literals: [{ value: 'test' }] }))
+      hardcodedPasswordAnalyzer.analyze(undefined)
+      hardcodedPasswordAnalyzer.analyze({ file: undefined })
+      hardcodedPasswordAnalyzer.analyze({ file, literals: undefined })
+      hardcodedPasswordAnalyzer.analyze({ file, literals: [{ value: undefined }] })
+      hardcodedPasswordAnalyzer.analyze({ file, literals: [{ value: 'test' }] })
     })
 
     it('should not report secrets in line 0', () => {
diff --git a/packages/dd-trace/test/appsec/iast/analyzers/hardcoded-secret-analyzer.spec.js b/packages/dd-trace/test/appsec/iast/analyzers/hardcoded-secret-analyzer.spec.js
@@ -1,6 +1,5 @@
 'use strict'
 
-const assert = require('node:assert/strict')
 const fs = require('node:fs')
 const os = require('node:os')
 const path = require('node:path')
@@ -58,11 +57,11 @@ describe('Hardcoded Secret Analyzer', () => {
     })
 
     it('should not fail with an malformed secrets', () => {
-      assert.doesNotThrow(() => hardcodedSecretAnalyzer.analyze(undefined))
-      assert.doesNotThrow(() => hardcodedSecretAnalyzer.analyze({ file: undefined }))
-      assert.doesNotThrow(() => hardcodedSecretAnalyzer.analyze({ file, literals: undefined }))
-      assert.doesNotThrow(() => hardcodedSecretAnalyzer.analyze({ file, literals: [{ value: undefined }] }))
-      assert.doesNotThrow(() => hardcodedSecretAnalyzer.analyze({ file, literals: [{ value: 'test' }] }))
+      hardcodedSecretAnalyzer.analyze(undefined)
+      hardcodedSecretAnalyzer.analyze({ file: undefined })
+      hardcodedSecretAnalyzer.analyze({ file, literals: undefined })
+      hardcodedSecretAnalyzer.analyze({ file, literals: [{ value: undefined }] })
+      hardcodedSecretAnalyzer.analyze({ file, literals: [{ value: 'test' }] })
     })
 
     it('should not report secrets in line 0', () => {
diff --git a/packages/dd-trace/test/appsec/iast/analyzers/vulnerability-analyzer.spec.js b/packages/dd-trace/test/appsec/iast/analyzers/vulnerability-analyzer.spec.js
@@ -139,7 +139,7 @@ describe('vulnerability-analyzer', () => {
     vulnerabilityAnalyzer._subscriptions[0].enable()
 
     const dc = require('dc-polyfill')
-    assert.doesNotThrow(() => { dc.channel('dd-trace:test:error:sub').publish({}) })
+    dc.channel('dd-trace:test:error:sub').publish({})
   })
 
   describe('addSub', () => {
diff --git a/packages/dd-trace/test/appsec/iast/taint-tracking/plugins/kafka.spec.js b/packages/dd-trace/test/appsec/iast/taint-tracking/plugins/kafka.spec.js
@@ -1,7 +1,5 @@
 'use strict'
 
-const assert = require('node:assert/strict')
-
 const { afterEach, beforeEach, describe, it } = require('mocha')
 const proxyquire = require('proxyquire')
 const sinon = require('sinon')
@@ -94,18 +92,14 @@ describe('Kafka consumer plugin', () => {
   it('should not fail with an unknown kafka message', () => {
     const message = {}
 
-    assert.doesNotThrow(() => {
-      handler({ message })
-    })
+    handler({ message })
   })
 
   it('should not fail with an unknown kafka message II', () => {
     const message = {
       key: 'key',
     }
 
-    assert.doesNotThrow(() => {
-      handler({ message })
-    })
+    handler({ message })
   })
 })
diff --git a/packages/dd-trace/test/appsec/iast/taint-tracking/rewriter.spec.js b/packages/dd-trace/test/appsec/iast/taint-tracking/rewriter.spec.js
@@ -16,11 +16,8 @@ const iastEnabledConfig = {
 
 describe('IAST Rewriter', () => {
   it('Addon should return a rewritter instance', () => {
-    let rewriter = null
-    assert.doesNotThrow(() => {
-      rewriter = require('@datadog/wasm-js-rewriter')
-    }, Error)
-    assert.notStrictEqual(rewriter, null)
+    const rewriter = require('@datadog/wasm-js-rewriter')
+    assert.ok(rewriter)
   })
 
   describe('Enabling rewriter', () => {
diff --git a/packages/dd-trace/test/appsec/iast/taint-tracking/taint-tracking-operations.spec.js b/packages/dd-trace/test/appsec/iast/taint-tracking/taint-tracking-operations.spec.js
@@ -74,10 +74,7 @@ describe('IAST TaintTracking Operations', () => {
   afterEach(sinon.restore)
 
   it('Addon should return a TaintedUtils instance', () => {
-    let TaintedUtils = null
-    assert.doesNotThrow(() => {
-      TaintedUtils = require('@datadog/native-iast-taint-tracking')
-    }, Error)
+    const TaintedUtils = require('@datadog/native-iast-taint-tracking')
     assert.notStrictEqual(TaintedUtils, null)
   })
 
diff --git a/packages/dd-trace/test/appsec/index.spec.js b/packages/dd-trace/test/appsec/index.spec.js
@@ -284,7 +284,7 @@ describe('AppSec Index', function () {
 
       sinon.stub(RuleManager, 'clearAllRules')
 
-      assert.doesNotThrow(AppSec.disable)
+      AppSec.disable()
 
       sinon.assert.calledOnce(RuleManager.clearAllRules)
     })
diff --git a/packages/dd-trace/test/crashtracking/crashtracker.spec.js b/packages/dd-trace/test/crashtracking/crashtracker.spec.js
@@ -73,7 +73,7 @@ describeNotWindows('crashtracker', () => {
     it('should handle errors', () => {
       crashtracker.start(null)
 
-      assert.doesNotThrow(() => crashtracker.start(config))
+      crashtracker.start(config)
     })
 
     it('should handle unix sockets', () => {
@@ -106,7 +106,7 @@ describeNotWindows('crashtracker', () => {
       crashtracker.start(config)
       crashtracker.configure(null)
 
-      assert.doesNotThrow(() => crashtracker.configure(config))
+      crashtracker.configure(config)
     })
   })
 
diff --git a/packages/dd-trace/test/llmobs/sdk/index.spec.js b/packages/dd-trace/test/llmobs/sdk/index.spec.js
@@ -182,8 +182,8 @@ describe('sdk', () => {
 
           llmobs.trace({ kind: 'workflow', name: 'myWorkflow' }, (span, cb) => {
             assert.ok(LLMObsTagger.tagMap.get(span) == null)
-            assert.doesNotThrow(() => span.setTag('k', 'v'))
-            assert.doesNotThrow(() => cb())
+            span.setTag('k', 'v')
+            cb()
           })
 
           sinon.assert.called(llmobs._tracer._processor.process)
@@ -378,7 +378,7 @@ describe('sdk', () => {
             assert.ok(LLMObsTagger.tagMap.get(llmobs._active()) == null)
           })
 
-          assert.doesNotThrow(() => fn(1))
+          fn(1)
 
           sinon.assert.called(llmobs._tracer._processor.process)
           sinon.assert.notCalled(LLMObsSpanProcessor.prototype.format)
@@ -1407,7 +1407,7 @@ describe('sdk', () => {
     it('logs if there was an error flushing', () => {
       LLMObsEvalMetricsWriter.prototype.flush.throws(new Error('boom'))
 
-      assert.doesNotThrow(() => llmobs.flush())
+      llmobs.flush()
     })
   })
 
diff --git a/packages/dd-trace/test/llmobs/span_processor.spec.js b/packages/dd-trace/test/llmobs/span_processor.spec.js
@@ -39,7 +39,7 @@ describe('span processor', () => {
     it('should do nothing if llmobs is not enabled', () => {
       processor = new LLMObsSpanProcessor({ llmobs: { enabled: false } })
 
-      assert.doesNotThrow(() => processor.process(span))
+      processor.process(span)
     })
 
     it('should do nothing if the span is not an llm obs span', () => {
diff --git a/packages/dd-trace/test/log.spec.js b/packages/dd-trace/test/log.spec.js
@@ -153,14 +153,12 @@ describe('log', () => {
     })
 
     it('should support chaining', () => {
-      assert.doesNotThrow(() => {
-        log
-          .use(logger)
-          .toggle(true)
-          .error('error')
-          .debug('debug')
-          .reset()
-      })
+      log
+        .use(logger)
+        .toggle(true)
+        .error('error')
+        .debug('debug')
+        .reset()
     })
 
     it('should call the logger in a noop context', () => {
diff --git a/packages/dd-trace/test/noop.spec.js b/packages/dd-trace/test/noop.spec.js
@@ -21,7 +21,7 @@ describe('NoopTracer', () => {
       tracer.trace('test', {}, (span, done) => {
         assert.ok(span instanceof Span)
         assert.strictEqual(typeof done, 'function')
-        assert.doesNotThrow(done)
+        done()
       })
     })
 
diff --git a/packages/dd-trace/test/openfeature/flagging_provider.spec.js b/packages/dd-trace/test/openfeature/flagging_provider.spec.js
@@ -91,8 +91,8 @@ describe('FlaggingProvider', () => {
     it('should handle null/undefined configuration gracefully', () => {
       const provider = new FlaggingProvider(mockTracer, mockConfig)
 
-      assert.doesNotThrow(() => provider._setConfiguration(null))
-      assert.doesNotThrow(() => provider._setConfiguration(undefined))
+      provider._setConfiguration(null)
+      provider._setConfiguration(undefined)
     })
   })
 
diff --git a/packages/dd-trace/test/openfeature/noop.spec.js b/packages/dd-trace/test/openfeature/noop.spec.js
diff --git a/packages/dd-trace/test/opentracing/tracer.spec.js b/packages/dd-trace/test/opentracing/tracer.spec.js
diff --git a/packages/dd-trace/test/plugin_manager.spec.js b/packages/dd-trace/test/plugin_manager.spec.js
diff --git a/packages/dd-trace/test/priority_sampler.spec.js b/packages/dd-trace/test/priority_sampler.spec.js
diff --git a/packages/dd-trace/test/scope.spec.js b/packages/dd-trace/test/scope.spec.js
diff --git a/packages/dd-trace/test/tagger.spec.js b/packages/dd-trace/test/tagger.spec.js

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ withVersions('express', 'express', version => {`
`79`	`79`	`// Router does not exist in Express 5`
`80`	`80`	`it('should work correctly when router[method] is called without handler', () => {`
`81`	`81`	`const router = express.Router()`
`82`		`- assert.doesNotThrow(() => { router.bind('/test') })`
	`82`	`+ router.bind('/test')`
`83`	`83`	`})`
`84`	`84`	`}`
`85`	`85`	`})`
Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ describe('Plugin', () => {`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`it('should skip injection without a store', async () => {`
`298`		`- assert.doesNotThrow(() => winston.info('message'))`
	`298`	`+ winston.info('message')`
`299`	`299`	`})`
`300`	`300`	`})`
`301`	`301`