[test optimization] Improve gatherPayloadsMaxTimeout error reporting (#7784)

juan-fernandez · web-flow · commit 9eaa73697b18 · 2026-03-16T15:23:47.000+01:00
diff --git a/integration-tests/ci-visibility-intake.js b/integration-tests/ci-visibility-intake.js
@@ -362,7 +362,8 @@ class FakeCiVisIntake extends FakeAgent {
             this.off('message', messageHandler)
             resolve()
           } catch (e) {
-            // we'll try again when a new payload arrives
+            // Assertion not yet satisfied — we'll try again when a new payload arrives.
+            // The timeout handler will re-run onPayload and reject with the actual error.
           }
         }
       }
diff --git a/integration-tests/cypress/cypress.spec.js b/integration-tests/cypress/cypress.spec.js
@@ -369,7 +369,7 @@ moduleTypes.forEach(({
               testTestEvent.content.meta[TEST_SOURCE_FILE].endsWith('spec-source-line.cy.ts'),
               `TEST_SOURCE_FILE should point to TypeScript source, got: ${testTestEvent.content.meta[TEST_SOURCE_FILE]}`
             )
-          }, 120000)
+          }, 60000)
 
         // Run Cypress with the pre-compiled JS spec (compiled from spec-source-line.cy.ts).
         // Cypress bundles the compiled JS via its own preprocessor; the plugin resolves
@@ -459,7 +459,7 @@ moduleTypes.forEach(({
               fallbackEvent.content.meta[TEST_SOURCE_FILE].endsWith('spec-source-line-fallback.cy.ts'),
               `TEST_SOURCE_FILE should point to TypeScript source, got: ${fallbackEvent.content.meta[TEST_SOURCE_FILE]}`
             )
-          }, 120000)
+          }, 60000)
 
         childProcess = exec(testCommand, {
           cwd,
@@ -507,7 +507,7 @@ moduleTypes.forEach(({
               noMatchEvent.content.meta[TEST_SOURCE_FILE].endsWith('spec-source-line-no-match.cy.ts'),
               `TEST_SOURCE_FILE should point to TypeScript source, got: ${noMatchEvent.content.meta[TEST_SOURCE_FILE]}`
             )
-          }, 120000)
+          }, 60000)
 
         childProcess = exec(testCommand, {
           cwd,
@@ -549,7 +549,7 @@ moduleTypes.forEach(({
               jsInvocationDetailsEvent.content.meta[TEST_SOURCE_FILE]
             }`
           )
-        }, 120000)
+        }, 60000)
 
       childProcess = exec(testCommand, {
         cwd,
@@ -1850,7 +1850,7 @@ moduleTypes.forEach(({
 
             const newTests = tests.filter(test => test.meta[TEST_IS_NEW] === 'true')
             assert.strictEqual(newTests.length, 0)
-          }, 120000)
+          }, 60000)
 
         const specToRun = 'cypress/e2e/spec.cy.js'
 
@@ -3285,7 +3285,7 @@ moduleTypes.forEach(({
             const tests = events.filter(event => event.type === 'test').map(event => event.content)
             // it is not retried
             assert.strictEqual(tests.length, 1)
-          }, 120000)
+          }, 60000)
 
         const {
           NODE_OPTIONS,
diff --git a/integration-tests/playwright/playwright.spec.js b/integration-tests/playwright/playwright.spec.js
@@ -685,7 +685,7 @@ versions.forEach((version) => {
 
             const retriedTests = tests.filter(test => test.meta[TEST_IS_RETRY] === 'true')
             assert.strictEqual(retriedTests.length, 0)
-          }, 120000)
+          }, 60000)
 
         childProcess = exec(
           './node_modules/.bin/playwright test -c playwright.config.js',

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,8 @@ class FakeCiVisIntake extends FakeAgent {`
`362`	`362`	`this.off('message', messageHandler)`
`363`	`363`	`resolve()`
`364`	`364`	`} catch (e) {`
`365`		`- // we'll try again when a new payload arrives`
	`365`	`+ // Assertion not yet satisfied — we'll try again when a new payload arrives.`
	`366`	`+ // The timeout handler will re-run onPayload and reject with the actual error.`
`366`	`367`	`}`
`367`	`368`	`}`
`368`	`369`	`}`