Skip to content

Commit 9b4ee01

Browse files
authored
chore(ci): retry flaky instrumentation-http in platform workflow (#7678)
Add retries (nick-fields/retry, 3 attempts) around the http instrumentation test steps to work around a flaky bug in Node.js http code. Inline the job steps instead of the shared action so only this job is affected. TODO: revert to ./.github/actions/ instrumentations/test once fixed upstream.
1 parent 8c83eac commit 9b4ee01

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

.github/workflows/platform.yml

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,37 @@ jobs:
199199
with:
200200
dd_api_key: ${{ secrets.DD_API_KEY }}
201201

202+
# TODO: Retries below work around a flaky bug in Node.js http code. Revert to using
203+
# ./.github/actions/instrumentations/test once fixed upstream.
202204
instrumentation-http:
203205
runs-on: ubuntu-latest
204206
env:
205207
PLUGINS: http
206208
steps:
207209
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
208-
- uses: ./.github/actions/instrumentations/test
210+
- uses: ./.github/actions/node/oldest-maintenance-lts
211+
- uses: ./.github/actions/install
212+
- name: Run instrumentation tests (oldest-maintenance, with retries)
213+
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3.0.2
209214
with:
210-
dd_api_key: ${{ secrets.DD_API_KEY }}
215+
max_attempts: 3
216+
timeout_minutes: 15
217+
command: yarn test:instrumentations:ci
218+
- uses: ./.github/actions/node/latest
219+
- name: Run instrumentation tests (latest, with retries)
220+
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3.0.2
221+
with:
222+
max_attempts: 3
223+
timeout_minutes: 15
224+
command: yarn test:instrumentations:ci
225+
- uses: ./.github/actions/coverage
226+
with:
227+
flags: instrumentations-${{ github.job }}
228+
- uses: DataDog/junit-upload-github-action@055560f63c405095e9228ba443eee7987e22bb94 # v2.1.1
229+
if: always() && github.actor != 'dependabot[bot]'
230+
with:
231+
api_key: ${{ secrets.DD_API_KEY }}
232+
service: dd-trace-js-tests
211233

212234
instrumentation-knex:
213235
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)