[DI] Ensure probes without a 'sampling' property is parsed correctly (#5090)

watson · web-flow · commit 71fc75fae39f · 2025-01-10T14:54:15.000+01:00
diff --git a/packages/dd-trace/src/debugger/devtools_client/breakpoints.js b/packages/dd-trace/src/debugger/devtools_client/breakpoints.js
@@ -23,10 +23,10 @@ async function addBreakpoint (probe) {
   delete probe.where
 
   // Optimize for fast calculations when probe is hit
-  const snapshotsPerSecond = probe.sampling.snapshotsPerSecond ?? (probe.captureSnapshot
+  const snapshotsPerSecond = probe.sampling?.snapshotsPerSecond ?? (probe.captureSnapshot
     ? MAX_SNAPSHOTS_PER_SECOND_PER_PROBE
     : MAX_NON_SNAPSHOTS_PER_SECOND_PER_PROBE)
-  probe.sampling.nsBetweenSampling = BigInt(1 / snapshotsPerSecond * 1e9)
+  probe.nsBetweenSampling = BigInt(1 / snapshotsPerSecond * 1e9)
   probe.lastCaptureNs = 0n
 
   // TODO: Inbetween `await session.post('Debugger.enable')` and here, the scripts are parsed and cached.
diff --git a/packages/dd-trace/src/debugger/devtools_client/index.js b/packages/dd-trace/src/debugger/devtools_client/index.js
@@ -42,7 +42,7 @@ session.on('Debugger.paused', async ({ params }) => {
     const id = params.hitBreakpoints[i]
     const probe = breakpoints.get(id)
 
-    if (start - probe.lastCaptureNs < probe.sampling.nsBetweenSampling) {
+    if (start - probe.lastCaptureNs < probe.nsBetweenSampling) {
       continue
     }
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ session.on('Debugger.paused', async ({ params }) => {`
`42`	`42`	`const id = params.hitBreakpoints[i]`
`43`	`43`	`const probe = breakpoints.get(id)`
`44`	`44`
`45`		`- if (start - probe.lastCaptureNs < probe.sampling.nsBetweenSampling) {`
	`45`	`+ if (start - probe.lastCaptureNs < probe.nsBetweenSampling) {`
`46`	`46`	`continue`
`47`	`47`	`}`
`48`	`48`