[bench] minor code-cleanup in the benchmarking script (#5105)

watson · web-flow · commit 6adf12180de3 · 2025-01-14T13:40:35.000+01:00
diff --git a/benchmark/sirun/run-all-variants.js b/benchmark/sirun/run-all-variants.js
@@ -4,7 +4,7 @@
 
 const fs = require('fs')
 const path = require('path')
-const { exec, getStdio } = require('./run-util')
+const { exec, stdio } = require('./run-util')
 
 process.env.DD_INSTRUMENTATION_TELEMETRY_ENABLED = 'false'
 
@@ -18,10 +18,10 @@ const env = Object.assign({}, process.env, { DD_TRACE_STARTUP_LOGS: 'false' })
     const variants = metaJson.variants
     for (const variant in variants) {
       const variantEnv = Object.assign({}, env, { SIRUN_VARIANT: variant })
-      await exec('sirun', ['meta-temp.json'], { env: variantEnv, stdio: getStdio() })
+      await exec('sirun', ['meta-temp.json'], { env: variantEnv, stdio })
     }
   } else {
-    await exec('sirun', ['meta-temp.json'], { env, stdio: getStdio() })
+    await exec('sirun', ['meta-temp.json'], { env, stdio })
   }
 
   try {
diff --git a/benchmark/sirun/run-one-variant.js b/benchmark/sirun/run-one-variant.js
@@ -2,10 +2,10 @@
 
 'use strict'
 
-const { exec, getStdio } = require('./run-util')
+const { exec, stdio } = require('./run-util')
 
 process.env.DD_INSTRUMENTATION_TELEMETRY_ENABLED = 'false'
 
 const env = Object.assign({}, process.env, { DD_TRACE_STARTUP_LOGS: 'false' })
 
-exec('sirun', ['meta-temp.json'], { env, stdio: getStdio() })
+exec('sirun', ['meta-temp.json'], { env, stdio })
diff --git a/benchmark/sirun/run-util.js b/benchmark/sirun/run-util.js
@@ -18,10 +18,6 @@ function exec (...args) {
   })
 }
 
-function getStdio () {
-  return ['inherit', 'pipe', 'inherit']
-}
-
 function streamAddVersion (input) {
   input.rl = readline.createInterface({ input })
   input.rl.on('line', function (line) {
@@ -39,6 +35,6 @@ function streamAddVersion (input) {
 
 module.exports = {
   exec,
-  getStdio,
+  stdio: ['inherit', 'pipe', 'inherit'],
   streamAddVersion
 }
