only load the naming schema version that is used (#5318)

rochdev · web-flow · commit 5963c08821d7 · 2025-02-26T09:34:12.000-05:00
diff --git a/packages/dd-trace/src/service-naming/index.js b/packages/dd-trace/src/service-naming/index.js
@@ -1,9 +1,7 @@
-const { schemaDefinitions } = require('./schemas')
-
 class SchemaManager {
   constructor () {
-    this.schemas = schemaDefinitions
-    this.config = { spanAttributeSchema: 'v0', spanRemoveIntegrationFromService: false }
+    this.schemas = {}
+    this.configure({ spanAttributeSchema: 'v0', spanRemoveIntegrationFromService: false })
   }
 
   get schema () {
@@ -31,6 +29,16 @@ class SchemaManager {
   }
 
   configure (config = {}) {
+    const { spanAttributeSchema, spanRemoveIntegrationFromService } = config
+
+    if (!this.schemas.v0 && spanAttributeSchema === 'v0') {
+      this.schemas.v0 = require('./schemas/v0')
+    }
+
+    if (!this.schemas.v1 && (spanAttributeSchema === 'v1' || spanRemoveIntegrationFromService)) {
+      this.schemas.v1 = require('./schemas/v1')
+    }
+
     this.config = config
   }
 }
diff --git a/packages/dd-trace/src/service-naming/schemas/index.js b/packages/dd-trace/src/service-naming/schemas/index.js
diff --git a/packages/dd-trace/test/setup/mocha.js b/packages/dd-trace/test/setup/mocha.js
@@ -10,7 +10,6 @@ const runtimeMetrics = require('../../src/runtime_metrics')
 const agent = require('../plugins/agent')
 const Nomenclature = require('../../src/service-naming')
 const { storage } = require('../../../datadog-core')
-const { schemaDefinitions } = require('../../src/service-naming/schemas')
 const { getInstrumentation } = require('./helpers/load-inst')
 
 global.withVersions = withVersions
@@ -35,7 +34,7 @@ function withNamingSchema (
   const testTitle = 'service and operation naming' + (desc !== '' ? ` (${desc})` : '')
 
   describe(testTitle, () => {
-    Object.keys(schemaDefinitions).forEach(versionName => {
+    ['v0', 'v1'].forEach(versionName => {
       describe(`in version ${versionName}`, () => {
         before(() => {
           fullConfig = Nomenclature.config
