Skip to content

Commit 3d1406e

Browse files
committed
Only exclude 8.16.0 from the esm tests
1 parent 217db9d commit 3d1406e

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

packages/datadog-instrumentations/src/elasticsearch.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ addHook({ name: '@elastic/transport', file: 'lib/Transport.js', versions: ['>=8'
1313
return exports
1414
})
1515

16-
addHook({ name: '@elastic/elasticsearch', file: 'lib/Transport.js', versions: ['>=5.6.16 <8', '>=8 <8.16.0'] }, Transport => {
16+
addHook({ name: '@elastic/elasticsearch', file: 'lib/Transport.js', versions: ['>=5.6.16 <8', '>=8'] }, Transport => {
1717
shimmer.wrap(Transport.prototype, 'request', createWrapRequest('elasticsearch'))
1818
shimmer.wrap(Transport.prototype, 'getConnection', createWrapGetConnection('elasticsearch'))
1919
return Transport

packages/datadog-plugin-elasticsearch/test/integration-test/client.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ describe('esm', () => {
1313
let proc
1414
let sandbox
1515

16-
withVersions('elasticsearch', ['@elastic/elasticsearch'], version => {
16+
// excluding 8.16.0 for esm tests, because it is not working: https://github.com/elastic/elasticsearch-js/issues/2466
17+
withVersions('elasticsearch', ['@elastic/elasticsearch'], '<8.16.0 || >8.16.0', version => {
1718
before(async function () {
1819
this.timeout(20000)
1920
sandbox = await createSandbox([`'@elastic/elasticsearch@${version}'`], false, [

0 commit comments

Comments
 (0)