Skip to content

Commit 3523cd6

Browse files
authored
ci: fix workflow name conflicts (#7388)
This could cause the all green check to believe everything passed while some checks did not pass due to former name conflicts. To verify this is not causing issues in the future, a CI check is added that tests against duplicate names.
1 parent c273d49 commit 3523cd6

File tree

10 files changed

+245
-0
lines changed

10 files changed

+245
-0
lines changed

.github/workflows/aiguard.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ env:
1717
jobs:
1818

1919
macos:
20+
name: ${{ github.workflow }} / macos
2021
runs-on: macos-latest
2122
steps:
2223
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -33,6 +34,7 @@ jobs:
3334
service: dd-trace-js-tests
3435

3536
ubuntu:
37+
name: ${{ github.workflow }} / ubuntu
3638
runs-on: ubuntu-latest
3739
steps:
3840
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -50,6 +52,7 @@ jobs:
5052
flags: aiguard-ubuntu
5153

5254
windows:
55+
name: ${{ github.workflow }} / windows
5356
runs-on: windows-latest
5457
steps:
5558
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -68,6 +71,7 @@ jobs:
6871
service: dd-trace-js-tests
6972

7073
integration:
74+
name: ${{ github.workflow }} / integration (node-${{ matrix.version }})
7175
strategy:
7276
matrix:
7377
version: [maintenance, active, latest]

.github/workflows/appsec.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ env:
2323

2424
jobs:
2525
macos:
26+
name: ${{ github.workflow }} / macos
2627
runs-on: macos-latest
2728
steps:
2829
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -39,6 +40,7 @@ jobs:
3940
service: dd-trace-js-tests
4041

4142
ubuntu:
43+
name: ${{ github.workflow }} / ubuntu
4244
runs-on: ubuntu-latest
4345
steps:
4446
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -61,6 +63,7 @@ jobs:
6163
service: dd-trace-js-tests
6264

6365
windows:
66+
name: ${{ github.workflow }} / windows
6467
runs-on: windows-latest
6568
steps:
6669
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -79,6 +82,7 @@ jobs:
7982
service: dd-trace-js-tests
8083

8184
ldapjs:
85+
name: ${{ github.workflow }} / ldapjs
8286
runs-on: ubuntu-latest
8387
env:
8488
PLUGINS: ldapjs
@@ -110,6 +114,7 @@ jobs:
110114
service: dd-trace-js-tests
111115

112116
postgres:
117+
name: ${{ github.workflow }} / postgres
113118
runs-on: ubuntu-latest
114119
services:
115120
postgres:
@@ -139,6 +144,7 @@ jobs:
139144
service: dd-trace-js-tests
140145

141146
mysql:
147+
name: ${{ github.workflow }} / mysql
142148
runs-on: ubuntu-latest
143149
services:
144150
mysql:
@@ -168,6 +174,7 @@ jobs:
168174
service: dd-trace-js-tests
169175

170176
express:
177+
name: ${{ github.workflow }} / express
171178
runs-on: ubuntu-latest
172179
env:
173180
PLUGINS: express|body-parser|cookie-parser|multer
@@ -188,6 +195,7 @@ jobs:
188195
service: dd-trace-js-tests
189196

190197
fastify:
198+
name: ${{ github.workflow }} / fastify
191199
runs-on: ubuntu-latest
192200
env:
193201
PLUGINS: fastify
@@ -208,6 +216,7 @@ jobs:
208216
service: dd-trace-js-tests
209217

210218
graphql:
219+
name: ${{ github.workflow }} / graphql
211220
runs-on: ubuntu-latest
212221
env:
213222
PLUGINS: apollo-server|apollo-server-express|apollo-server-fastify|apollo-server-core
@@ -228,6 +237,7 @@ jobs:
228237
service: dd-trace-js-tests
229238

230239
mongodb-core:
240+
name: ${{ github.workflow }} / mongodb-core
231241
runs-on: ubuntu-latest
232242
services:
233243
mongodb:
@@ -254,6 +264,7 @@ jobs:
254264
service: dd-trace-js-tests
255265

256266
mongoose:
267+
name: ${{ github.workflow }} / mongoose
257268
runs-on: ubuntu-latest
258269
services:
259270
mongodb:
@@ -338,6 +349,7 @@ jobs:
338349
range_clean: gte.14.2.7.and.lt.15
339350
- range: ">=15.0.0"
340351
range_clean: gte.15.0.0
352+
name: ${{ github.workflow }} / next (node-${{ matrix.version }}, ${{ matrix.range_clean }})
341353
runs-on: ubuntu-latest
342354
env:
343355
PLUGINS: next
@@ -364,6 +376,7 @@ jobs:
364376
service: dd-trace-js-tests
365377

366378
lodash:
379+
name: ${{ github.workflow }} / lodash
367380
runs-on: ubuntu-latest
368381
env:
369382
PLUGINS: lodash
@@ -387,6 +400,7 @@ jobs:
387400
strategy:
388401
matrix:
389402
version: [oldest, maintenance, active, latest]
403+
name: ${{ github.workflow }} / integration (node-${{ matrix.version }})
390404
runs-on: ubuntu-latest
391405
steps:
392406
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -442,6 +456,7 @@ jobs:
442456
service: dd-trace-js-tests
443457

444458
node-serialize:
459+
name: ${{ github.workflow }} / node-serialize
445460
runs-on: ubuntu-latest
446461
env:
447462
PLUGINS: node-serialize

.github/workflows/debugger.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ env:
1616

1717
jobs:
1818
ubuntu:
19+
name: ${{ github.workflow }} / ubuntu (node-${{ matrix.version }})
1920
strategy:
2021
matrix:
2122
version: [oldest, maintenance, active, latest]

.github/workflows/openfeature.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
strategy:
2020
matrix:
2121
version: [oldest, maintenance, active, latest]
22+
name: ${{ github.workflow }} / unit (node-${{ matrix.version }})
2223
runs-on: ubuntu-latest
2324
steps:
2425
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -42,6 +43,7 @@ jobs:
4243
service: dd-trace-js-tests
4344

4445
macos:
46+
name: ${{ github.workflow }} / macos
4547
runs-on: macos-latest
4648
steps:
4749
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -55,6 +57,7 @@ jobs:
5557
service: dd-trace-js-tests
5658

5759
ubuntu:
60+
name: ${{ github.workflow }} / ubuntu
5861
runs-on: ubuntu-latest
5962
steps:
6063
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -74,6 +77,7 @@ jobs:
7477
service: dd-trace-js-tests
7578

7679
windows:
80+
name: ${{ github.workflow }} / windows
7781
runs-on: windows-latest
7882
steps:
7983
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/platform.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,7 @@ jobs:
403403
fail-fast: false
404404
matrix:
405405
version: [oldest, maintenance, active, latest]
406+
name: ${{ github.workflow }} / integration (node-${{ matrix.version }})
406407
runs-on: ubuntu-latest
407408
steps:
408409
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/profiling.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ env:
2323

2424
jobs:
2525
macos:
26+
name: ${{ github.workflow }} / macos
2627
runs-on: macos-latest
2728
steps:
2829
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -40,6 +41,7 @@ jobs:
4041
service: dd-trace-js-tests
4142

4243
ubuntu:
44+
name: ${{ github.workflow }} / ubuntu
4345
runs-on: ubuntu-latest
4446
steps:
4547
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -66,6 +68,7 @@ jobs:
6668
service: dd-trace-js-tests
6769

6870
windows:
71+
name: ${{ github.workflow }} / windows
6972
runs-on: windows-latest
7073
steps:
7174
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/project.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,15 @@ jobs:
5959
- uses: ./.github/actions/install
6060
- run: npm run verify-exercised-tests
6161

62+
workflow-job-names:
63+
runs-on: ubuntu-latest
64+
name: Workflow job names (unique)
65+
steps:
66+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
67+
- uses: ./.github/actions/node/latest
68+
- uses: ./.github/actions/install
69+
- run: npm run verify:workflow-job-names
70+
6271
# The package size is especially useful in constrained environments, so the
6372
# computation is done only on the package that would be installed there.
6473
# In order to do that, the current folder is wiped and replaced with what

.github/workflows/test-optimization.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ jobs:
4040
strategy:
4141
matrix:
4242
version: [oldest, maintenance, active, latest]
43+
name: ${{ github.workflow }} / integration (node-${{ matrix.version }})
4344
runs-on: ubuntu-latest
4445
steps:
4546
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
"test:unit:plugins": "mocha \"packages/datadog-instrumentations/test/@($(echo $PLUGINS)).spec.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/*.spec.js\" --exclude \"packages/datadog-plugin-@($(echo $PLUGINS))/test/integration-test/**/*.spec.js\"",
7676
"test:shimmer": "mocha \"packages/datadog-shimmer/test/**/*.spec.js\"",
7777
"test:shimmer:ci": "nyc --no-clean --include \"packages/datadog-shimmer/src/**/*.js\" -- npm run test:shimmer",
78+
"verify:workflow-job-names": "node scripts/verify-workflow-job-names.js",
7879
"verify-exercised-tests": "node scripts/verify-exercised-tests.js"
7980
},
8081
"repository": {

0 commit comments

Comments
 (0)