remaps http status tag to meet ddog convention for otel(#4384)

zarirhamza · ida613 · commit 321451c27ae9 · 2024-06-10T13:36:42.000-04:00
diff --git a/packages/dd-trace/src/opentelemetry/span.js b/packages/dd-trace/src/opentelemetry/span.js
@@ -179,11 +179,19 @@ class Span {
   }
 
   setAttribute (key, value) {
+    if (key === 'http.response.status_code') {
+      this._ddSpan.setTag('http.status_code', value.toString())
+    }
+
     this._ddSpan.setTag(key, value)
     return this
   }
 
   setAttributes (attributes) {
+    if ('http.response.status_code' in attributes) {
+      attributes['http.status_code'] = attributes['http.response.status_code'].toString()
+    }
+
     this._ddSpan.addTags(attributes)
     return this
   }
diff --git a/packages/dd-trace/test/opentelemetry/span.spec.js b/packages/dd-trace/test/opentelemetry/span.spec.js
@@ -287,6 +287,26 @@ describe('OTel Span', () => {
     expect(_tags).to.have.property('baz', 'buz')
   })
 
+  describe('should remap http.response.status_code', () => {
+    it('should remap when setting attributes', () => {
+      const span = makeSpan('name')
+
+      const { _tags } = span._ddSpan.context()
+
+      span.setAttributes({ 'http.response.status_code': 200 })
+      expect(_tags).to.have.property('http.status_code', '200')
+    })
+
+    it('should remap when setting singular attribute', () => {
+      const span = makeSpan('name')
+
+      const { _tags } = span._ddSpan.context()
+
+      span.setAttribute('http.response.status_code', 200)
+      expect(_tags).to.have.property('http.status_code', '200')
+    })
+  })
+
   it('should set span links', () => {
     const span = makeSpan('name')
     const span2 = makeSpan('name2')

Original file line number	Diff line number	Diff line change
`@@ -179,11 +179,19 @@ class Span {`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`setAttribute (key, value) {`
	`182`	`+ if (key === 'http.response.status_code') {`
	`183`	`+ this._ddSpan.setTag('http.status_code', value.toString())`
	`184`	`+ }`
	`185`	`+`
`182`	`186`	`this._ddSpan.setTag(key, value)`
`183`	`187`	`return this`
`184`	`188`	`}`
`185`	`189`
`186`	`190`	`setAttributes (attributes) {`
	`191`	`+ if ('http.response.status_code' in attributes) {`
	`192`	`+ attributes['http.status_code'] = attributes['http.response.status_code'].toString()`
	`193`	`+ }`
	`194`	`+`
`187`	`195`	`this._ddSpan.addTags(attributes)`
`188`	`196`	`return this`
`189`	`197`	`}`