fix(test-optimization): no advanced features are enabled if ITR kill switch is passed through environment variables (#7141)

calvinbayer · web-flow · commit 2d19e95fbfef · 2026-01-26T13:42:07.000+01:00
diff --git a/packages/dd-trace/src/ci-visibility/exporters/ci-visibility-exporter.js b/packages/dd-trace/src/ci-visibility/exporters/ci-visibility-exporter.js
@@ -103,10 +103,6 @@ class CiVisibilityExporter extends BufferingExporter {
     )
   }
 
-  shouldRequestLibraryConfiguration () {
-    return this._config.isIntelligentTestRunnerEnabled
-  }
-
   canReportSessionTraces () {
     return this._canUseCiVisProtocol
   }
@@ -163,9 +159,6 @@ class CiVisibilityExporter extends BufferingExporter {
   getLibraryConfiguration (testConfiguration, callback) {
     const { repositoryUrl } = testConfiguration
     this.sendGitMetadata(repositoryUrl)
-    if (!this.shouldRequestLibraryConfiguration()) {
-      return callback(null, {})
-    }
     this._canUseCiVisProtocolPromise.then((canUseCiVisProtocol) => {
       if (!canUseCiVisProtocol) {
         return callback(null, {})
diff --git a/packages/dd-trace/test/ci-visibility/exporters/ci-visibility-exporter.spec.js b/packages/dd-trace/test/ci-visibility/exporters/ci-visibility-exporter.spec.js
@@ -106,21 +106,6 @@ describe('CI Visibility Exporter', () => {
         done()
       })
     })
-    context('if ITR is disabled', () => {
-      it('should resolve immediately and not request settings', (done) => {
-        const scope = nock(url)
-          .post('/api/v2/libraries/tests/services/setting')
-          .reply(200)
-
-        const ciVisibilityExporter = new CiVisibilityExporter({ port })
-        ciVisibilityExporter.getLibraryConfiguration({}, (err, libraryConfig) => {
-          assert.deepStrictEqual(libraryConfig, {})
-          assert.strictEqual(err, null)
-          assert.notStrictEqual(scope.isDone(), true)
-          done()
-        })
-      })
-    })
     context('if ITR is enabled', () => {
       it('should add custom configurations', (done) => {
         let customConfig
@@ -278,7 +263,6 @@ describe('CI Visibility Exporter', () => {
           port, isIntelligentTestRunnerEnabled: true
         })
         ciVisibilityExporter._resolveCanUseCiVisProtocol(true)
-        assert.strictEqual(ciVisibilityExporter.shouldRequestLibraryConfiguration(), true)
         ciVisibilityExporter.getLibraryConfiguration({}, (err, libraryConfig) => {
           assert.strictEqual(scope.isDone(), true)
           assert.strictEqual(err, null)
@@ -320,7 +304,6 @@ describe('CI Visibility Exporter', () => {
           port, isIntelligentTestRunnerEnabled: true
         })
         ciVisibilityExporter._resolveCanUseCiVisProtocol(true)
-        assert.strictEqual(ciVisibilityExporter.shouldRequestLibraryConfiguration(), true)
         ciVisibilityExporter.getLibraryConfiguration({}, (err, libraryConfig) => {
           assert.strictEqual(scope.isDone(), true)
           assert.strictEqual(err, null)

Original file line number	Diff line number	Diff line change
`@@ -103,10 +103,6 @@ class CiVisibilityExporter extends BufferingExporter {`
`103`	`103`	`)`
`104`	`104`	`}`
`105`	`105`
`106`		`- shouldRequestLibraryConfiguration () {`
`107`		`- return this._config.isIntelligentTestRunnerEnabled`
`108`		`- }`
`109`		`-`
`110`	`106`	`canReportSessionTraces () {`
`111`	`107`	`return this._canUseCiVisProtocol`
`112`	`108`	`}`
`@@ -163,9 +159,6 @@ class CiVisibilityExporter extends BufferingExporter {`
`163`	`159`	`getLibraryConfiguration (testConfiguration, callback) {`
`164`	`160`	`const { repositoryUrl } = testConfiguration`
`165`	`161`	`this.sendGitMetadata(repositoryUrl)`
`166`		`- if (!this.shouldRequestLibraryConfiguration()) {`
`167`		`- return callback(null, {})`
`168`		`- }`
`169`	`162`	`this._canUseCiVisProtocolPromise.then((canUseCiVisProtocol) => {`
`170`	`163`	`if (!canUseCiVisProtocol) {`
`171`	`164`	`return callback(null, {})`